Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Update default RPM build vars #3245

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Oct 16, 2024

PMM-7

This PR:

  • updates the default RPM build variables after we stopped building RHEL7
  • removes the redundant Dockerfile(s) for RHEL7-based rpmbuild images

@ademidoff ademidoff requested a review from a team as a code owner October 16, 2024 11:42
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team October 16, 2024 11:42
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.25%. Comparing base (6712d56) to head (2c7ffe3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3245      +/-   ##
==========================================
+ Coverage   43.22%   43.25%   +0.02%     
==========================================
  Files         399      399              
  Lines       41725    41725              
==========================================
+ Hits        18037    18047      +10     
+ Misses      21680    21667      -13     
- Partials     2008     2011       +3     
Flag Coverage Δ
admin 11.61% <ø> (ø)
agent 52.24% <ø> (+0.13%) ⬆️
managed 44.43% <ø> (-0.01%) ⬇️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff requested a review from a team as a code owner October 16, 2024 15:26
@ademidoff ademidoff requested review from BupycHuk and removed request for a team October 16, 2024 15:26
@ademidoff ademidoff merged commit 7cdb659 into main Oct 17, 2024
31 checks passed
@ademidoff ademidoff deleted the PMM-7-update-default-rpmbuild-vars branch October 17, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants