Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-11180 upgrade matrix #3246

Merged
merged 47 commits into from
Oct 18, 2024
Merged

PMM-11180 upgrade matrix #3246

merged 47 commits into from
Oct 18, 2024

Conversation

BupycHuk
Copy link
Member

PMM-11180

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested review from a team and JiriCtvrtka as code owners October 16, 2024 14:54
@BupycHuk BupycHuk requested review from ademidoff and idoqo and removed request for a team October 16, 2024 14:54
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 43.45%. Comparing base (7108418) to head (b1b2bff).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
agent/agents/mysql/perfschema/perfschema.go 57.14% 2 Missing and 1 partial ⚠️
agent/utils/tests/mongodb.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #3246   +/-   ##
=======================================
  Coverage   43.45%   43.45%           
=======================================
  Files         360      360           
  Lines       43933    43947   +14     
=======================================
+ Hits        19090    19098    +8     
- Misses      23186    23189    +3     
- Partials     1657     1660    +3     
Flag Coverage Δ
admin 11.49% <ø> (ø)
agent 51.93% <70.00%> (+0.02%) ⬆️
managed 45.17% <ø> (-0.01%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

},
PKFieldIndex: -1,
},
z: new(eventsStatementsHistory).Values(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[go-consistent] reported by reviewdog 🐶
zero value ptr alloc: use &T{} for *T allocation

Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BupycHuk BupycHuk merged commit 6a67936 into v3 Oct 18, 2024
32 checks passed
@BupycHuk BupycHuk deleted the PMM-11180-upgrade-matrix branch October 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants