PS-7809: Add backward compatibilty after removing rdb_comparator and …

…using RocksDB::BytewiseComparator instead
percona · Feb 27, 2025 · d20dc8e · d20dc8e
1 parent 29005f0
commit d20dc8e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/db/version_edit_handler.cc b/db/version_edit_handler.cc
@@ -214,6 +214,10 @@ Status VersionEditHandler::ApplyVersionEdit(VersionEdit& edit,
   }
   if (s.ok()) {
     assert(cfd != nullptr);
+    if (edit.comparator_ == "RocksDB_SE_v3.10")
+      edit.comparator_ = "leveldb.BytewiseComparator";
+    if (edit.comparator_ == "rev:RocksDB_SE_v3.10")
+      edit.comparator_ = "rocksdb.ReverseBytewiseComparator";
     s = ExtractInfoFromVersionEdit(*cfd, edit);
   }
   return s;

diff --git a/options/options_parser.cc b/options/options_parser.cc
@@ -306,6 +306,11 @@ Status RocksDBOptionsParser::Parse(const ConfigOptions& config_options_in,
       if (!s.ok()) {
         return s;
       }
+      if (name == "comparator") {
+        if (value == "RocksDB_SE_v3.10") value = "leveldb.BytewiseComparator";
+        if (value == "rev:RocksDB_SE_v3.10")
+          value = "rocksdb.ReverseBytewiseComparator";
+      }
       opt_map.insert({name, value});
     }
   }