Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification categories and actions #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cri-tech
Copy link

@cri-tech cri-tech commented Aug 2, 2021

I modified the database to have categories on notifications as well as registration for different categories for the user.

I also added the possibility of having actions (for compatible browsers) in the notifications.

Todo :

  • improve the entry of actions in the send form

I modified the database to have categories on notifications as well as registration for different categories for the user.

I still have to manage the creation of categories in the backoffice,

I also added the possibility of having actions (for compatible browsers) in the notifications.

Todo :
- improve the entry of actions in the send form
@rwngallego
Copy link
Collaborator

Thanks @cri-tech, we will take a look at your PR :)

Maybe @MocioF would you like to see how it works? Looks like cool stuff :)

@MocioF
Copy link
Contributor

MocioF commented Aug 9, 2021

I will look at this in this week.

@MocioF
Copy link
Contributor

MocioF commented Aug 16, 2021

@rwngallego can you check the docker files? I cannot create a docker image to test this:

Step 3/8 : RUN apt-get install -y vim subversion mariadb-client wget
---> Running in dc0eaedb4caf
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package vim
E: Unable to locate package subversion
E: Unable to locate package mariadb-client
E: Unable to locate package wget

@rwngallego
Copy link
Collaborator

@MocioF please check the latest master, we're now switching to the 5.8 apache docker image.

@MocioF
Copy link
Contributor

MocioF commented Aug 28, 2021

@rwngallego Sorry for my delay, but I still have some problems in testing this commit, because I am not able to use the docker image. I'm working on a gentoo machine, so the problem could be I don't have apt installed

@rwngallego
Copy link
Collaborator

@MocioF I can extract the changes and rebase our master branch there so that it works with the latest changes. I'll update you when I get some time to do it and probably send a separate PR.

@simohammedhttp
Copy link

Hi, are there any updates related to those waited features?
I have a multilingual website with PolyLang, I wonder how to send separate campaigns for each locale?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants