fix: Do not load RediSearch on non x86_64 Fedoras #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgtm - this looks like a good way to do it |
richm
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non x86_64 builds of Redis do not support the RediSearch extension on Fedora distro. As such, use of the redis sub-role fails on non x86_64 architectures as the RediSearch is enforced on all architectures supported by Fedora.
This fix allows use of the RediSearch extension on Fedora distro, only when run on x86_64 architecture.
@richm can you please review this pull request ? There might be a better way how to achieve the required outcome and you are more experienced.