switching to right-aligned pointer; closes dev-cafe#208

this is also consistent with google c++ style guide

.clang-format

@@ -43,7 +43,7 @@ PenaltyBreakFirstLessLess: 120
 PenaltyBreakString: 1000
 PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 200
-PointerAlignment: Middle
+PointerAlignment: Right
 SpaceAfterCStyleCast: false
 SpaceBeforeAssignmentOperators: true
 SpaceBeforeParens: ControlStatements

Chapter01/recipe-03/cxx-example/Message.cpp

@@ -3,7 +3,7 @@
 #include <iostream>
 #include <string>
 
-std::ostream & Message::printObject(std::ostream & os) {
+std::ostream &Message::printObject(std::ostream &os) {
   os << "This is my very nice message: " << std::endl;
   os << message_;
 

Chapter01/recipe-03/cxx-example/Message.hpp

@@ -5,13 +5,13 @@
 
 class Message {
 public:
-  Message(const std::string & m) : message_(m) {}
+  Message(const std::string &m) : message_(m) {}
 
-  friend std::ostream & operator<<(std::ostream & os, Message & obj) {
+  friend std::ostream &operator<<(std::ostream &os, Message &obj) {
     return obj.printObject(os);
   }
 
 private:
   std::string message_;
-  std::ostream & printObject(std::ostream & os);
+  std::ostream &printObject(std::ostream &os);
 };

Chapter01/recipe-03/cxx-objlib-example/Message.cpp

@@ -3,7 +3,7 @@
 #include <iostream>
 #include <string>
 
-std::ostream & Message::printObject(std::ostream & os) {
+std::ostream &Message::printObject(std::ostream &os) {
   os << "This is my very nice message: " << std::endl;
   os << message_;
 

Chapter01/recipe-03/cxx-objlib-example/Message.hpp

@@ -5,13 +5,13 @@
 
 class Message {
 public:
-  Message(const std::string & m) : message_(m) {}
+  Message(const std::string &m) : message_(m) {}
 
-  friend std::ostream & operator<<(std::ostream & os, Message & obj) {
+  friend std::ostream &operator<<(std::ostream &os, Message &obj) {
     return obj.printObject(os);
   }
 
 private:
   std::string message_;
-  std::ostream & printObject(std::ostream & os);
+  std::ostream &printObject(std::ostream &os);
 };

Chapter01/recipe-04/cxx-example/Message.cpp

@@ -3,7 +3,7 @@
 #include <iostream>
 #include <string>
 
-std::ostream & Message::printObject(std::ostream & os) {
+std::ostream &Message::printObject(std::ostream &os) {
   os << "This is my very nice message: " << std::endl;
   os << message_;
 

Chapter01/recipe-04/cxx-example/Message.hpp

@@ -5,13 +5,13 @@
 
 class Message {
 public:
-  Message(const std::string & m) : message_(m) {}
+  Message(const std::string &m) : message_(m) {}
 
-  friend std::ostream & operator<<(std::ostream & os, Message & obj) {
+  friend std::ostream &operator<<(std::ostream &os, Message &obj) {
     return obj.printObject(os);
   }
 
 private:
   std::string message_;
-  std::ostream & printObject(std::ostream & os);
+  std::ostream &printObject(std::ostream &os);
 };

Chapter01/recipe-06/cxx-example/Message.cpp

@@ -3,7 +3,7 @@
 #include <iostream>
 #include <string>
 
-std::ostream & Message::printObject(std::ostream & os) {
+std::ostream &Message::printObject(std::ostream &os) {
   os << "This is my very nice message: " << std::endl;
   os << message_;
 

Chapter01/recipe-06/cxx-example/Message.hpp

@@ -5,13 +5,13 @@
 
 class Message {
 public:
-  Message(const std::string & m) : message_(m) {}
+  Message(const std::string &m) : message_(m) {}
 
-  friend std::ostream & operator<<(std::ostream & os, Message & obj) {
+  friend std::ostream &operator<<(std::ostream &os, Message &obj) {
     return obj.printObject(os);
   }
 
 private:
   std::string message_;
-  std::ostream & printObject(std::ostream & os);
+  std::ostream &printObject(std::ostream &os);
 };

Chapter01/recipe-10/cxx-example/Animal.cpp

@@ -2,6 +2,6 @@
 
 #include <string>
 
-Animal::Animal(const std::string & n) : name_(n) {}
+Animal::Animal(const std::string &n) : name_(n) {}
 
 std::string Animal::name() const { return name_impl(); }

Chapter01/recipe-10/cxx-example/Animal.hpp

@@ -5,7 +5,7 @@
 class Animal {
 public:
   Animal() = delete;
-  explicit Animal(const std::string & n);
+  explicit Animal(const std::string &n);
   std::string name() const;
 
 protected:

Chapter01/recipe-10/cxx-example/Cat.hpp

@@ -4,7 +4,7 @@
 
 class Cat final : public Animal {
 public:
-  Cat(const std::string & n) : Animal(n) {}
+  Cat(const std::string &n) : Animal(n) {}
 
 private:
   std::string name_impl() const override;

Chapter01/recipe-10/cxx-example/Dog.hpp

@@ -4,7 +4,7 @@
 
 class Dog final : public Animal {
 public:
-  Dog(const std::string & n) : Animal(n) {}
+  Dog(const std::string &n) : Animal(n) {}
 
 private:
   std::string name_impl() const override;

Chapter01/recipe-10/cxx-example/Factory.hpp

@@ -44,7 +44,7 @@ template <typename CreateObject> class BaseFactory {
   /*! \brief Retrieve constant iterator from map given object identifier
    * \param[in] objID  the object's identification string
    */
-  CallbackConstIter retrieve(const std::string & objID) const {
+  CallbackConstIter retrieve(const std::string &objID) const {
     if (objID.empty())
       ERROR("No object identification string provided to the Factory.");
     CallbackConstIter i = callbacks_.find(objID);
@@ -58,13 +58,13 @@ template <typename CreateObject> class BaseFactory {
    * \param[in] objID  the object's identification string
    * \param[in] functor the creation function related to the object type given
    */
-  bool registerObject(const std::string & objID, const CreateObject & functor) {
+  bool registerObject(const std::string &objID, const CreateObject &functor) {
     return callbacks_.insert(CallbackPair(objID, functor)).second;
   }
   /*! \brief Returns true if objID was already registered
    *  \param objID the object's identification string
    */
-  bool unRegisterObject(const std::string & objID) {
+  bool unRegisterObject(const std::string &objID) {
     return callbacks_.erase(objID) == 1;
   }
 
@@ -73,15 +73,15 @@ template <typename CreateObject> class BaseFactory {
    * \param[in] objID  the object's identification string
    * \param[in] functor the creation function related to the object type given
    */
-  void subscribe(const std::string & objID, const CreateObject & functor) {
+  void subscribe(const std::string &objID, const CreateObject &functor) {
     bool done = this->registerObject(objID, functor);
     if (!done)
       ERROR("Subscription of object ID " + objID + " to factory failed!");
   }
   /*! \brief Unsubscribes object with objID from factory
    *  \param objID the object's identification string
    */
-  void unsubscribe(const std::string & objID) {
+  void unsubscribe(const std::string &objID) {
     bool done = this->unRegisterObject(objID);
     if (!done)
       ERROR("Unsubscription of object ID " + objID + " from factory failed!");
@@ -113,7 +113,7 @@ class Factory final : public detail::BaseFactory<CreateObject> {
    */
   template <typename... ObjectInputArgs>
   typename std::result_of<CreateObject(ObjectInputArgs...)>::type create(
-      const std::string & objID,
+      const std::string &objID,
       ObjectInputArgs... data) const {
     return (this->retrieve(objID)->second)(data...);
   }

Chapter01/recipe-10/cxx-example/animal-farm.cpp

@@ -13,9 +13,9 @@ typedef std::function<std::unique_ptr<Animal>(const std::string &)> CreateAnimal
 int main() {
   Factory<CreateAnimal> farm;
   farm.subscribe("CAT",
-                 [](const std::string & n) { return std::make_unique<Cat>(n); });
+                 [](const std::string &n) { return std::make_unique<Cat>(n); });
   farm.subscribe("DOG",
-                 [](const std::string & n) { return std::make_unique<Dog>(n); });
+                 [](const std::string &n) { return std::make_unique<Dog>(n); });
 
   std::unique_ptr<Animal> simon = farm.create("CAT", "Simon");
   std::unique_ptr<Animal> marlowe = farm.create("DOG", "Marlowe");

Chapter03/recipe-03/cxx-example/Py2-pure-embedding.cpp

@@ -5,7 +5,7 @@
 
 #include <Python.h>
 
-int main(int argc, char * argv[]) {
+int main(int argc, char *argv[]) {
   PyObject *pName, *pModule, *pDict, *pFunc;
   PyObject *pArgs, *pValue;
   int i;

Chapter03/recipe-03/cxx-example/Py3-pure-embedding.cpp

@@ -5,7 +5,7 @@
 
 #include <Python.h>
 
-int main(int argc, char * argv[]) {
+int main(int argc, char *argv[]) {
   PyObject *pName, *pModule, *pDict, *pFunc;
   PyObject *pArgs, *pValue;
   int i;

Chapter03/recipe-04/cxx-example/CxxBLAS.cpp

@@ -122,23 +122,23 @@ void C_DGEMM(char transa,
              int n,
              int k,
              double alpha,
-             double * a,
+             double *a,
              int lda,
-             double * b,
+             double *b,
              int ldb,
              double beta,
-             double * c,
+             double *c,
              int ldc) {
   if (m == 0 || n == 0 || k == 0)
     return;
   ::F_DGEMM(&transb, &transa, &n, &m, &k, &alpha, b, &ldb, a, &lda, &beta, c, &ldc);
 }
 
-void C_DSCAL(size_t length, double alpha, double * vec, int inc) {
+void C_DSCAL(size_t length, double alpha, double *vec, int inc) {
   int big_blocks = (int)(length / INT_MAX);
   int small_size = (int)(length % INT_MAX);
   for (int block = 0; block <= big_blocks; block++) {
-    double * vec_s = &vec[block * inc * (size_t)INT_MAX];
+    double *vec_s = &vec[block * inc * (size_t)INT_MAX];
     signed int length_s = (block == big_blocks) ? small_size : INT_MAX;
     ::F_DSCAL(&length_s, &alpha, vec_s, &inc);
   }

Chapter03/recipe-04/cxx-example/CxxBLAS.hpp

@@ -25,7 +25,7 @@ extern void F_DGEMM(char *,
                     int *);
 
 #define F_DSCAL dscal_
-extern void F_DSCAL(int * n, double * alpha, double * vec, int * inc);
+extern void F_DSCAL(int *n, double *alpha, double *vec, int *inc);
 
 #ifdef __cplusplus
 }
@@ -37,12 +37,12 @@ void C_DGEMM(char transa,
              int n,
              int k,
              double alpha,
-             double * a,
+             double *a,
              int lda,
-             double * b,
+             double *b,
              int ldb,
              double beta,
-             double * c,
+             double *c,
              int ldc);
 
 /*!
@@ -54,4 +54,4 @@ void C_DGEMM(char transa,
  * \param inc    how many places to skip to get to next element in vec
  *
  */
-void C_DSCAL(size_t length, double alpha, double * vec, int inc);
+void C_DSCAL(size_t length, double alpha, double *vec, int inc);

Chapter03/recipe-04/cxx-example/CxxLAPACK.cpp

@@ -55,7 +55,7 @@
  *                singular, so the solution could not be computed.
  *
  */
-int C_DGESV(int n, int nrhs, double * a, int lda, int * ipiv, double * b, int ldb) {
+int C_DGESV(int n, int nrhs, double *a, int lda, int *ipiv, double *b, int ldb) {
   int info;
   ::F_DGESV(&n, &nrhs, a, &lda, ipiv, b, &ldb, &info);
   return info;
@@ -101,10 +101,10 @@ int C_DGESV(int n, int nrhs, double * a, int lda, int * ipiv, double * b, int ld
 int C_DSYEV(char jobz,
             char uplo,
             int n,
-            double * A,
+            double *A,
             int lda,
-            double * w,
-            double * work,
+            double *w,
+            double *work,
             int lwork) {
   int info;
 

Chapter03/recipe-04/cxx-example/CxxLAPACK.hpp

@@ -18,13 +18,13 @@ F_DSYEV(char *, char *, int *, double *, int *, double *, double *, int *, int *
 }
 #endif
 
-int C_DGESV(int n, int nrhs, double * a, int lda, int * ipiv, double * b, int ldb);
+int C_DGESV(int n, int nrhs, double *a, int lda, int *ipiv, double *b, int ldb);
 
 int C_DSYEV(char jobz,
             char uplo,
             int n,
-            double * a,
+            double *a,
             int lda,
-            double * w,
-            double * work,
+            double *w,
+            double *work,
             int lwork);

Chapter03/recipe-04/cxx-example/linear-algebra.cpp

@@ -10,7 +10,7 @@
 #include "CxxBLAS.hpp"
 #include "CxxLAPACK.hpp"
 
-int main(int argc, char ** argv) {
+int main(int argc, char **argv) {
   if (argc != 2) {
     std::cout << "Usage: ./linear-algebra dim" << std::endl;
     return EXIT_FAILURE;

Chapter03/recipe-05/cxx-example/hello-openmp.cpp

@@ -21,7 +21,7 @@
  *    Roberto Di Remigio
  */
 
-int main(int argc, char * argv[]) {
+int main(int argc, char *argv[]) {
   std::cout << "\n";
   std::cout << "HELLO_OPENMP" << std::endl;
   std::cout << "  C++11/OpenMP version" << std::endl;

Chapter03/recipe-06/cxx-example/hello-mpi.cpp

@@ -12,7 +12,7 @@
 
 #include <mpi.h>
 
-int main(int argc, char ** argv) {
+int main(int argc, char **argv) {
   // Initialize the MPI environment. The two arguments to MPI Init are not
   // currently used by MPI implementations, but are there in case future
   // implementations might need the arguments.

Chapter03/recipe-07/cxx-example/linear-algebra.cpp

@@ -6,7 +6,7 @@
 
 #include <Eigen/Dense>
 
-int main(int argc, char ** argv) {
+int main(int argc, char **argv) {
   if (argc != 2) {
     std::cout << "Usage: ./linear-algebra dim" << std::endl;
     return EXIT_FAILURE;

Chapter03/recipe-08/cxx-example/path-info.cpp

@@ -15,9 +15,9 @@
 using namespace std;
 using namespace boost::filesystem;
 
-const char * say_what(bool b) { return b ? "true" : "false"; }
+const char *say_what(bool b) { return b ? "true" : "false"; }
 
-int main(int argc, char * argv[]) {
+int main(int argc, char *argv[]) {
   if (argc < 2) {
     cout
         << "Usage: path_info path-element [path-element...]\n"

Chapter04/recipe-01/cxx-example/main.cpp

@@ -5,7 +5,7 @@
 
 // we assume all arguments are integers and we sum them up
 // for simplicity we do not verify the type of arguments
-int main(int argc, char * argv[]) {
+int main(int argc, char *argv[]) {
 
   std::vector<int> integers;
   for (int i = 1; i < argc; i++) {

Chapter04/recipe-01/cxx-example/sum_integers.cpp

@@ -4,7 +4,7 @@
 
 int sum_integers(const std::vector<int> integers) {
   int sum = 0;
-  for (auto & i : integers) {
+  for (auto &i : integers) {
     sum += i;
   }
   return sum;