Stricter release plan: more checks

Checked dist DBI-1.647.tgz Kwalitee rating 157.89% (30/19)
perl5-dbi · Jan 17, 2025 · 5845db5 · 5845db5
1 parent f0f9b38
commit 5845db5
Show file tree

Hide file tree

Showing 10 changed files with 24 additions and 18 deletions.
diff --git a/DBI.pm b/DBI.pm
@@ -16,7 +16,7 @@ use warnings;
 
 our ($XS_VERSION, $VERSION);
 BEGIN {
-$VERSION = "1.646"; # ==> ALSO update the version in the pod text below!
+$VERSION = "1.647"; # ==> ALSO update the version in the pod text below!
 $XS_VERSION = $VERSION;
 $VERSION =~ tr/_//d;
 }
@@ -148,7 +148,7 @@ sure that your issue isn't related to the driver you're using.
 
 =head2 NOTES
 
-This is the DBI specification that corresponds to DBI version 1.646
+This is the DBI specification that corresponds to DBI version 1.647
 (see L<DBI::Changes> for details).
 
 The DBI is evolving at a steady pace, so it's good to check that

diff --git a/Makefile.PL b/Makefile.PL
@@ -381,19 +381,25 @@ checkkeywords:
 	find . -type f \( -name .svn -prune -o -name \*.pm -o -name \*.PL -o -name \*.pl \) \
             -exec bash -c '[ -z "$$(svn pg svn:keywords {})" ] && echo svn propset svn:keywords \"Id Revision\" {}' \;
 
-.PHONY:	doc change changes spellcheck checkpod
+.PHONY:	doc change changes spellcheck checkpod newdist
 changes:	$(changes_pm1)
 doc:
 	perl doc/make-doc.pl --pod
+spellcheck checkpod:	doc
+	pod-spell-check -i -a doc/*.pod
+
 dbipport:
 	perl sandbox/genPPPort_h.pl
 ppport:		dbipport.h
-	perl dbipport.h --compat-version=5.8.0 DBI.xs
-
-tgzdist:	changes doc dist
-
-spellcheck checkpod:	doc
-	pod-spell-check -i -a doc/*.pod
+	perl dbipport.h --compat-version=5.8.1 DBI.xs
+
+# make dist does not remove existing .tar.gz causing questions
+newdist:
+	-@rm -f $(DISTVNAME).tar.gz $(DISTVNAME).tgz
+tgzdist:	changes spellcheck newdist dist
+	-@mv -f $(DISTVNAME).tar.gz $(DISTVNAME).tgz
+	-@cpants_lint.pl $(DISTVNAME).tgz
+	-@rm -f Debian_CPANTS.txt
 };
 
     return $xst;

diff --git a/doc/DBD-Gofer-Transport-Base.3 b/doc/DBD-Gofer-Transport-Base.3
@@ -150,7 +150,7 @@ Returns true (would like to retry), false (must not retry), undef (no preference
 .PP
 If a true value is returned in the form of a CODE ref then, if DBD::Gofer does
 decide to retry the request, it calls the code ref passing \f(CW$retry_count\fR, \f(CW$retry_limit\fR.
-Can be used for logging and/or to implement exponential backoff behaviour.
+Can be used for logging and/or to implement exponential back\-off behaviour.
 Currently the called code must return using \f(CW\*(C`return;\*(C'\fR to allow for future extensions.
 .SH AUTHOR
 .IX Header "AUTHOR"

diff --git a/doc/DBD-Gofer-Transport-Base.html b/doc/DBD-Gofer-Transport-Base.html
@@ -114,7 +114,7 @@ <h2 id="response_retry_preference">response_retry_preference</h2>
 
 <p>Returns true (would like to retry), false (must not retry), undef (no preference).</p>
 
-<p>If a true value is returned in the form of a CODE ref then, if DBD::Gofer does decide to retry the request, it calls the code ref passing $retry_count, $retry_limit. Can be used for logging and/or to implement exponential backoff behaviour. Currently the called code must return using <code>return;</code> to allow for future extensions.</p>
+<p>If a true value is returned in the form of a CODE ref then, if DBD::Gofer does decide to retry the request, it calls the code ref passing $retry_count, $retry_limit. Can be used for logging and/or to implement exponential back-off behaviour. Currently the called code must return using <code>return;</code> to allow for future extensions.</p>
 
 <h1 id="AUTHOR">AUTHOR</h1>
 

diff --git a/doc/DBD-Gofer-Transport-Base.man b/doc/DBD-Gofer-Transport-Base.man
@@ -89,7 +89,7 @@ METHODS
        If a true value is returned in the form of a CODE ref then, if
        DBD::Gofer does decide to retry the request, it calls the code ref
        passing $retry_count, $retry_limit.  Can be used for logging and/or to
-       implement exponential backoff behaviour.  Currently the called code
+       implement exponential back-off behaviour.  Currently the called code
        must return using "return;" to allow for future extensions.
 
 AUTHOR

diff --git a/doc/DBD-Gofer-Transport-Base.md b/doc/DBD-Gofer-Transport-Base.md
@@ -89,7 +89,7 @@ Returns true (would like to retry), false (must not retry), undef (no preference
 
 If a true value is returned in the form of a CODE ref then, if DBD::Gofer does
 decide to retry the request, it calls the code ref passing $retry\_count, $retry\_limit.
-Can be used for logging and/or to implement exponential backoff behaviour.
+Can be used for logging and/or to implement exponential back-off behaviour.
 Currently the called code must return using `return;` to allow for future extensions.
 
 # AUTHOR

diff --git a/doc/DBD-Multiplex.3 b/doc/DBD-Multiplex.3
@@ -186,7 +186,7 @@ any errors, and returning all of the results.
 \&\fBlast_result_most_common\fR
 .Sp
 Execute the requested method against each child handle, not stopping after
-the errors, and returning the most common result (eg three\-way\-voting etc).
+the errors, and returning the most common result (e.g. three\-way\-voting etc).
 Not yet implemented.
 .IP \fBmx_shuffle\fR 4
 .IX Item "mx_shuffle"

diff --git a/doc/DBD-Multiplex.html b/doc/DBD-Multiplex.html
@@ -139,7 +139,7 @@ <h1 id="SPECIFIC-ATTRIBUTES">SPECIFIC ATTRIBUTES</h1>
 
 <p><b>last_result_most_common</b></p>
 
-<p>Execute the requested method against each child handle, not stopping after the errors, and returning the most common result (eg three-way-voting etc). Not yet implemented.</p>
+<p>Execute the requested method against each child handle, not stopping after the errors, and returning the most common result (e.g. three-way-voting etc). Not yet implemented.</p>
 
 </dd>
 <dt id="mx_shuffle"><b>mx_shuffle</b></dt>

diff --git a/doc/DBD-Multiplex.man b/doc/DBD-Multiplex.man
@@ -123,8 +123,8 @@ SPECIFIC ATTRIBUTES
            last_result_most_common
 
            Execute the requested method against each child handle, not
-           stopping after the errors, and returning the most common result (eg
-           three-way-voting etc).  Not yet implemented.
+           stopping after the errors, and returning the most common result
+           (e.g. three-way-voting etc).  Not yet implemented.
 
        mx_shuffle
            Shuffles the list of child handles each time it's about to be used.

diff --git a/doc/DBD-Multiplex.md b/doc/DBD-Multiplex.md
@@ -129,7 +129,7 @@ The following specific attributes can be set when connecting:
     **last\_result\_most\_common**
 
     Execute the requested method against each child handle, not stopping after
-    the errors, and returning the most common result (eg three-way-voting etc).
+    the errors, and returning the most common result (e.g. three-way-voting etc).
     Not yet implemented.
 
 - **mx\_shuffle**