Add left side memory view #216
Annotations
17 warnings
casting to the same type is unnecessary (`usize` -> `usize`):
src/gui_vizia/components/mem.rs#L61
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/gui_vizia/components/mem.rs:61:47
|
61 | ... .get(&((i.0 + 3) as usize))
| ^^^^^^^^^^^^^^^^^^^^ help: try: `{ (i.0 + 3) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
unnecessary closure used to substitute value for `Option::None`:
src/gui_vizia/components/mem.rs#L59
warning: unnecessary closure used to substitute value for `Option::None`
--> src/gui_vizia/components/mem.rs:59:37
|
59 | / ... mem.0
60 | | ... .borrow()
61 | | ... .get(&((i.0 + 3) as usize))
62 | | ... .copied()
63 | | ... .unwrap_or_else(|| 0u8)
| |____________________________---------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/gui_vizia/components/mem.rs#L56
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/gui_vizia/components/mem.rs:56:47
|
56 | ... .get(&((i.0 + 2) as usize))
| ^^^^^^^^^^^^^^^^^^^^ help: try: `{ (i.0 + 2) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
unnecessary closure used to substitute value for `Option::None`:
src/gui_vizia/components/mem.rs#L54
warning: unnecessary closure used to substitute value for `Option::None`
--> src/gui_vizia/components/mem.rs:54:37
|
54 | / ... mem.0
55 | | ... .borrow()
56 | | ... .get(&((i.0 + 2) as usize))
57 | | ... .copied()
58 | | ... .unwrap_or_else(|| 0u8),
| |____________________________---------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/gui_vizia/components/mem.rs#L51
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/gui_vizia/components/mem.rs:51:47
|
51 | ... .get(&((i.0 + 1) as usize))
| ^^^^^^^^^^^^^^^^^^^^ help: try: `{ (i.0 + 1) }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
src/gui_vizia/components/mem.rs#L49
warning: unnecessary closure used to substitute value for `Option::None`
--> src/gui_vizia/components/mem.rs:49:37
|
49 | / ... mem.0
50 | | ... .borrow()
51 | | ... .get(&((i.0 + 1) as usize))
52 | | ... .copied()
53 | | ... .unwrap_or_else(|| 0u8),
| |____________________________---------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L347
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:347:21
|
347 | / self.memory
348 | | .0
349 | | .borrow()
350 | | .get(&(i.0 + 3))
351 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L342
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:342:21
|
342 | / self.memory
343 | | .0
344 | | .borrow()
345 | | .get(&(i.0 + 2))
346 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L337
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:337:21
|
337 | / self.memory
338 | | .0
339 | | .borrow()
340 | | .get(&(i.0 + 1))
341 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/components/mem.rs#L336
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/components/mem.rs:336:48
|
336 | self.memory.0.borrow().get(&(i.0)).unwrap_or_else(|| &0u8),
| ^^^^^^ help: change this to: `(i.0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L336
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:336:21
|
336 | self.memory.0.borrow().get(&(i.0)).unwrap_or_else(|| &0u8),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------------
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L347
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:347:21
|
347 | / self.memory
348 | | .0
349 | | .borrow()
350 | | .get(&(i.0 + 3))
351 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L342
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:342:21
|
342 | / self.memory
343 | | .0
344 | | .borrow()
345 | | .get(&(i.0 + 2))
346 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L337
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:337:21
|
337 | / self.memory
338 | | .0
339 | | .borrow()
340 | | .get(&(i.0 + 1))
341 | | .unwrap_or_else(|| &0u8),
| |__________________________----------------------^
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/components/mem.rs#L336
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/components/mem.rs:336:48
|
336 | self.memory.0.borrow().get(&(i.0)).unwrap_or_else(|| &0u8),
| ^^^^^^ help: change this to: `(i.0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unnecessary closure used to substitute value for `Option::None`:
src/components/mem.rs#L336
warning: unnecessary closure used to substitute value for `Option::None`
--> src/components/mem.rs:336:21
|
336 | self.memory.0.borrow().get(&(i.0)).unwrap_or_else(|| &0u8),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-----------------------
| |
| help: use `unwrap_or(..)` instead: `unwrap_or(&0u8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|