Skip to content

remove redundant offset set to make clippy happy #252

remove redundant offset set to make clippy happy

remove redundant offset set to make clippy happy #252

Triggered via push October 8, 2023 17:05
Status Failure
Total duration 15m 35s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
this function takes 3 arguments but 2 arguments were supplied: src/main.rs#L22
error[E0061]: this function takes 3 arguments but 2 arguments were supplied --> src/main.rs:22:5 | 22 | syncrim::gui_egui::gui(cs, &_path).ok(); | ^^^^^^^^^^^^^^^^^^^^^^------------ an argument of type `syncrim::gui_egui::editor::Library` is missing | note: function defined here --> /home/runner/work/syncrim/syncrim/src/gui_egui/gui.rs:43:8 | 43 | pub fn gui(cs: ComponentStore, path: &PathBuf, library: Library) -> Result<(), eframe::Error> { | ^^^ help: provide the argument | 22 | syncrim::gui_egui::gui(cs, &_path, /* syncrim::gui_egui::editor::Library */).ok(); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
build
Clippy had exited with the 101 exit code
all variants have the same prefix: `Update`: src/gui_vizia/components/mem.rs#L95
warning: all variants have the same prefix: `Update` --> src/gui_vizia/components/mem.rs:95:1 | 95 | / pub enum DataEvent { 96 | | UpdateClock, 97 | | UpdateScroll(Range<usize>), 98 | | UpdateView(Range<usize>), 99 | | } | |_^ | = help: remove the prefixes and use full paths to the variants instead of glob imports = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names = note: `#[warn(clippy::enum_variant_names)]` on by default
method `default` can be confused for the standard trait method `std::default::Default::default`: src/gui_egui/editor.rs#L81
warning: method `default` can be confused for the standard trait method `std::default::Default::default` --> src/gui_egui/editor.rs:81:5 | 81 | / pub fn default() -> Library { 82 | | let dummy_input = Input::new("id", "field"); 83 | | let library: Components = vec![ 84 | | Rc::new(Add { ... | 137 | | Library(library) 138 | | } | |_____^ | = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait = note: `#[warn(clippy::should_implement_trait)]` on by default
unused import: `Library`: src/gui_egui/keymap.rs#L2
warning: unused import: `Library` --> src/gui_egui/keymap.rs:2:51 | 2 | use crate::gui_egui::editor::{Editor, EditorMode, Library}; | ^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/