Merge with dev #275
Annotations
1 error and 11 warnings
build
Process completed with exit code 101.
|
rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unused `std::result::Result` that must be used:
src/gui_vizia/gui.rs#L131
warning: unused `std::result::Result` that must be used
--> src/gui_vizia/gui.rs:131:5
|
131 | / Application::new(move |cx| {
132 | | cx.add_stylesheet(include_style!("src/gui_vizia/style.css"))
133 | | .expect("Failed to add stylesheet");
134 | |
... |
346 | | .title("SyncRim")
347 | | .run();
| |__________^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
131 | let _ = Application::new(move |cx| {
| +++++++
|
use of a fallible conversion when an infallible one could be used:
src/simulator.rs#L233
warning: use of a fallible conversion when an infallible one could be used
--> src/simulator.rs:233:38
|
233 | let val: SignalValue = value.try_into().unwrap();
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `impl Into<SignalValue>` to `SignalValue` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
|
233 - let val: SignalValue = value.try_into().unwrap();
233 + let val: SignalValue = value.into();
|
|
unused variable: `ex`:
src/gui_vizia/components/probe_edit.rs#L37
warning: unused variable: `ex`
--> src/gui_vizia/components/probe_edit.rs:37:34
|
37 | .on_submit(move |ex, text, enter| {
| ^^ help: if this is intentional, prefix it with an underscore: `_ex`
|
= note: `#[warn(unused_variables)]` on by default
|
unused import: `crate::gui_vizia::popup::popup_data_derived_lenses::is_open`:
src/gui_vizia/popup.rs#L9
warning: unused import: `crate::gui_vizia::popup::popup_data_derived_lenses::is_open`
--> src/gui_vizia/popup.rs:9:5
|
9 | use crate::gui_vizia::popup::popup_data_derived_lenses::is_open;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
use of a fallible conversion when an infallible one could be used:
src/simulator.rs#L233
warning: use of a fallible conversion when an infallible one could be used
--> src/simulator.rs:233:38
|
233 | let val: SignalValue = value.try_into().unwrap();
| ^^^^^^^^^^^^^^^^^^^
|
= note: converting `impl Into<SignalValue>` to `SignalValue` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
help: use
|
233 - let val: SignalValue = value.try_into().unwrap();
233 + let val: SignalValue = value.into();
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/common.rs#L159
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/common.rs:159:9
|
159 | context.id_tmp = self.get_id_ports().0.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `context.id_tmp.clone_from(&self.get_id_ports().0)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`:
src/gui_egui/editor_wire_mode.rs#L101
warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`
--> src/gui_egui/editor_wire_mode.rs:101:21
|
101 | #[allow(clippy::vtable_address_comparisons)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons`
|
lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`:
src/gui_egui/editor.rs#L413
warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons`
--> src/gui_egui/editor.rs:413:17
|
413 | #[allow(clippy::vtable_address_comparisons)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|