Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding anova to plausibility function #25

Merged
merged 29 commits into from
Mar 3, 2025
Merged

Conversation

ManonSimonot
Copy link
Collaborator

No description provided.

@ManonSimonot ManonSimonot linked an issue Feb 7, 2025 that may be closed by this pull request
@ManonSimonot
Copy link
Collaborator Author

For the error in test_coverage, I saw that we need to update to actions/upload-artifact@v4 in the .github/workflows/test-coverage.yaml file. Unfortunately I can't seem to have permission to modify this file.

Other errors come from quarto vignettes, I found issues related to this problem but did not find solutions:

Could you investigate these issues?
Thanks!

@astamm
Copy link
Collaborator

astamm commented Feb 7, 2025

It seems that the windows build fail and the pkgdown fail are not due to the same issue. I fixed the former following the suggestion here:

For the latter, can you investigate why this package pkgdown GHA works: https://github.com/jolars/qualpalr ? It seems to be set up exactly like ours.

@ManonSimonot
Copy link
Collaborator Author

I checked the package website and on the vignette it is written that it comes from vignettes/introduction.Rmd, even if on the github the vignette is a qmd document.

@astamm
Copy link
Collaborator

astamm commented Feb 7, 2025

See: https://github.com/jolars/qualpalr/actions/runs/12234664397/job/34124326950. The job ends well and manages to process the .qmd.

@astamm
Copy link
Collaborator

astamm commented Feb 10, 2025

The actions setup-r-dependencies actually already includes quarto install.

@ManonSimonot
Copy link
Collaborator Author

I tried adding things present in the package you mentioned earlier but I don't really understand what I'm doing (I never did those kind of things), maybe you should try to fix the issue because I don't think that I'm really helping unfortunately

@astamm astamm merged commit 8b62795 into permaverse:master Mar 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vignettes
2 participants