Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cancellations and duplicate diagnostics #17

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

perrinjerome
Copy link
Owner

No description provided.

@perrinjerome perrinjerome force-pushed the fix/cancellation-and-duplicate-diagnostics branch 2 times, most recently from 7d4958b to 8826409 Compare March 27, 2022 14:47
@codecov-commenter
Copy link

Codecov Report

Merging #17 (0f61364) into main (0e28dac) will decrease coverage by 0.23%.
The diff coverage is 88.88%.

❗ Current head 0f61364 differs from pull request most recent head 8826409. Consider uploading reports for the commit 8826409 to get more accurate results

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   95.64%   95.40%   -0.24%     
==========================================
  Files          27       27              
  Lines        2296     2330      +34     
==========================================
+ Hits         2196     2223      +27     
- Misses        100      107       +7     
Impacted Files Coverage Δ
server/buildoutls/buildout.py 95.53% <88.70%> (-0.94%) ⬇️
server/buildoutls/tests/conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e28dac...8826409. Read the comment docs.

@perrinjerome perrinjerome force-pushed the fix/cancellation-and-duplicate-diagnostics branch from 8826409 to 03b9661 Compare March 27, 2022 14:55
@perrinjerome perrinjerome force-pushed the main branch 5 times, most recently from 8cdc2a2 to 933ddb8 Compare April 2, 2022 22:58
@perrinjerome perrinjerome force-pushed the fix/cancellation-and-duplicate-diagnostics branch from 03b9661 to 813dd5f Compare July 17, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants