Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add under review action from upstream control_msgs #3

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

egordon
Copy link
Contributor

@egordon egordon commented Aug 12, 2021

While waiting on ros-controls/control_msgs#60, we can use this implementation internaly.

Copy link

@amalnanavati amalnanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll just have to be careful to change all code that refers to these messages from pr_control_msgs::JointGroupCommand to control_msgs::JointGroupCommand when the upstream PR gets merged.

@egordon egordon merged commit f00de06 into master Aug 13, 2021
@egordon egordon deleted the egordon/control_msgs branch August 13, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants