[NO-PAPI] Enhance updated since filter description #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajki
reviewed
Jun 12, 2024
personio-personnel-data-api-oa3.yaml
Outdated
| @@ -1934,7 +1934,7 @@ paths: | |||
| - name: end_date | |||
| in: query | |||
| required: false | |||
| description: Filter by absence periods that start at or before given date. | |||
| description: Filter by absence periods that start at or after given date. | |||
There was a problem hiding this comment.
question: Is this an intentional change? It should be before, right?
There was a problem hiding this comment.
@rajki, I fixed the description. It's a bit confusing in terms of which periods are included 😅
rajki
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.