Skip to content

Commit

Permalink
feat(metrics): remove dst_zone label, reduce number of latency buckets
Browse files Browse the repository at this point in the history
The buckets of the metrics are reduced to:
1, 10, 50, 100, 200, 300, 400, 500, 1000, 5000, 10000

zone (availability zone) is totally removed
  • Loading branch information
bruce-personio committed Sep 9, 2024
1 parent 5c5b9a9 commit 4d2b245
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion linkerd/app/core/src/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ where
let mut out = format!("{}_{}=\"{}\"", prefix, k0, v0);

for (k, v) in labels_iter {
if k == "pod" || k == "pod_template_hash" {
if k == "pod" || k == "pod_template_hash" || k == "zone" {
continue;
}

Expand Down
14 changes: 0 additions & 14 deletions linkerd/metrics/src/latency.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,30 +6,16 @@ use super::histogram::{Bounds, Bucket, Histogram};
/// milliseconds.
pub const BOUNDS: &Bounds = &Bounds(&[
Bucket::Le(1.0),
Bucket::Le(2.0),
Bucket::Le(3.0),
Bucket::Le(4.0),
Bucket::Le(5.0),
Bucket::Le(10.0),
Bucket::Le(20.0),
Bucket::Le(30.0),
Bucket::Le(40.0),
Bucket::Le(50.0),
Bucket::Le(100.0),
Bucket::Le(200.0),
Bucket::Le(300.0),
Bucket::Le(400.0),
Bucket::Le(500.0),
Bucket::Le(1_000.0),
Bucket::Le(2_000.0),
Bucket::Le(3_000.0),
Bucket::Le(4_000.0),
Bucket::Le(5_000.0),
Bucket::Le(10_000.0),
Bucket::Le(20_000.0),
Bucket::Le(30_000.0),
Bucket::Le(40_000.0),
Bucket::Le(50_000.0),
// A final upper bound.
Bucket::Inf,
]);
Expand Down

0 comments on commit 4d2b245

Please sign in to comment.