Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] added ssl_verify=True to the head of the btcde.py file, use thi… #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holg
Copy link

@holg holg commented Sep 3, 2021

Added doge and xrp to the definitions, also added ssl_verify=True to the head of the btcde.py file

…s variable for the requests Method to enable ssl verify and change it centrally
@CosmicDuck CosmicDuck mentioned this pull request Mar 24, 2022
@peshay
Copy link
Owner

peshay commented Mar 24, 2022

I see you have two different changes in this PR, is it possible to split them up in two different commits?

  1. Add currencies

  2. Add option for ssl_verify

I think the ssl_verify = True could be an option in the Connection object, for example

class Connection(object):
    """To provide connection credentials to the trading API"""
    def __init__(self, api_key, api_secret, ssl_verify=False):

I put it in here as default False, mainly to not change the behaviour of the Code.

It would be also great if you could review unit tests and README to include, test and document your change. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants