Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFMPEG demuxer cleanup #122

Open
wants to merge 9 commits into
base: ffpesdemux
Choose a base branch
from
Open

FFMPEG demuxer cleanup #122

wants to merge 9 commits into from

Conversation

rofafor
Copy link
Contributor

@rofafor rofafor commented Jun 30, 2018 •
edited
Loading

TODO:

@pesintta @rofafor
Switch over to ffmpeg audio demuxer
f76df2c 
Audio packet handling is tricky; they are decoded by the same thread that
feeds them. If the thread is blocked waiting for input too long we get vdr
complaining about TS packet not accepted in tranfer mode and playback gets
broken.

In other words we cannot wait for more input so if buffer gets empty we run
into trouble.

The code needs to ensure that this never happens (old code tries to do this).

Better alternative would be to move audio decoder into audio playback thread.
This is the approach that video decoder already has.
@rofafor rofafor changed the title Demuxer cleanup FFMPEG demuxer cleanup Jun 30, 2018
@rofafor rofafor mentioned this pull request Jun 30, 2018
Open
@rofafor rofafor force-pushed the ffpesdemux branch 2 times, most recently from 3d6e398 to 97e225f Compare June 30, 2018 18:47
@rofafor rofafor force-pushed the ffpesdemux branch 6 times, most recently from 9bc7586 to 1939a13 Compare July 21, 2018 07:21
@rofafor rofafor mentioned this pull request Aug 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rofafor @pesintta