fixed some failing specs

petabridge · Apr 13, 2024 · 5121d7f · 5121d7f
1 parent e21b848
commit 5121d7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 19 deletions.
diff --git a/tests/TurboMqtt.Core.Tests/Packets/Connect/ConnectFlagsSpecs.cs b/tests/TurboMqtt.Core.Tests/Packets/Connect/ConnectFlagsSpecs.cs
@@ -14,10 +14,10 @@ public class ConnectFlagsSpecs
     public class when_creating_connect_flags
     {
         [Fact]
-        public void it_should_have_clean_session_flag_set_to_true_by_default()
+        public void it_should_have_clean_session_flag_set_to_false_by_default()
         {
             var flags = new ConnectFlags();
-            flags.CleanSession.Should().BeTrue();
+            flags.CleanSession.Should().BeFalse();
         }
 
         [Fact]

diff --git a/tests/TurboMqtt.Core.Tests/Packets/Connect/ConnectPacketMqtt311Specs.cs b/tests/TurboMqtt.Core.Tests/Packets/Connect/ConnectPacketMqtt311Specs.cs
@@ -105,22 +105,6 @@ [Fact] public void should_have_correct_payload()
         }
     }
 
-    // create a test case for working with username and password
-    public class WhenCreatingUsernameAndPassword
-    {
-        [Fact] public void should_have_correct_username_password()
-        {
-            var password = new byte[] { 1, 2, 3 };
-            var connectPacket = new ConnectPacket("clientId", MqttProtocolVersion.V3_1_1)
-            {
-                Username = "username",
-                Password = password,
-            };
-            connectPacket.Username.Should().Be("username");
-            connectPacket.Password.Should().BeEquivalentTo(password);
-        }
-    }
-
     // create test cases for estimating the size of the packet
     public class WhenEstimatingPacketSize
     {
@@ -129,7 +113,7 @@ [Fact] public void should_estimate_correct_size()
             var connectPacket = new ConnectPacket("clientId", MqttProtocolVersion.V3_1_1)
             {
                 Username = "username",
-                Password = new byte[] { 1, 2, 3 },
+                Password = new ReadOnlyMemory<byte>(new byte[] { 1, 2, 3 }),
                 Will = new MqttLastWill("topic", new byte[] { 1, 2, 3 }),
                 ReceiveMaximum = 10, // should be ignored - only supported in MQTT 5.0
                 MaximumPacketSize = 100, // should be ignored - only supported in MQTT 5.0