Python client implementation #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
main
branch
2 times, most recently
from
5333dfa
to
3cdc76d
Compare
|
This is great! Thank you :)) Maybe we can add it to an examples folder? |
Sharpz7
reviewed
Jul 31, 2023
| "max_length": max_length, | ||
| } | ||
| self.ws.send(json.dumps(payload)) | ||
| assert json.loads(self.ws.recv())['ok'] == True |
There was a problem hiding this comment.
Suggested change
| assert json.loads(self.ws.recv())['ok'] == True | |
| assert json.loads(self.ws.recv())['ok'] is True |
Sharpz7
reviewed
Jul 31, 2023
| while True: | ||
| data = json.loads(self.ws.recv()) | ||
| if not data['ok']: | ||
| raise Exception(data['traceback']) |
There was a problem hiding this comment.
Would be nice to have a more specific exception here.
borzunov
force-pushed
the
main
branch
2 times, most recently
from
39e7998
to
08f21f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I've implemented simple Python client. Feel free to merge it if you find it useful.