log message not complete #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdeneux
requested changes
Jun 15, 2018
There was a problem hiding this comment.
Hi Guillaume,
In your commit you mix changes about the issue #1 and other changes. Please don't mix:
- one commit for the issue only, in this PR,
- another commit, in another PR to use correctly log formatter in all classes of the SE Mapping.
| @@ -52,8 +52,8 @@ public MappingSuManager(final AbstractServiceEngine component) { | |||
|
|
|||
| @Override | |||
| protected void doDeploy(final ServiceUnitDataHandler suDH) throws PEtALSCDKException { | |||
| if (this.logger.isLoggable(Level.FINE)) { | |||
| this.logger.fine("Deploying specific part of SU = " + suDH.getName() + ") ..."); | |||
| if (this.logger.isLoggable(Level.FINE)&& suDH != null) { | |||
There was a problem hiding this comment.
Here suDH must be not null. Unneeded to check it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A message log contains %s format instead of operation name
WARNING [Petals.Container.Components.petals-se-mapping] : An operation '%s' is defined into the 3PP service provider definition in the JBI descriptor. It won't be used, remove it !!
issue #1