Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 6 RXJS 6 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamzamensi
Copy link

please merge it

@peterbsmyth
Copy link
Owner

We needed to use this PR so we published an npm package called 'ngx-breadcrumbs-ui'. If you are using ngx-breadcrumbs with angular six you can swap the npm dependencies and fix your app with this work-around.

@jpargana
Copy link

Hi @peterbsmith2. Thanks for your workaround. I tried to put your npm module working and everything work fine in dev enviroment. But running ng build --prod, an error was happens.

ERROR in ./node_modules/ngx-breadcrumbs-ui/ngx-breadcrumbs.ngfactory.js
Module not found: Error: Can't resolve 'ngx-breadcrumbs' in '[...]/node_modules/ngx-breadcrumbs-ui'

I tried to change "importAs":"ngx-breadcrumbs" to "importAs":"ngx-breadcrumbs-ui" in ngx-breadcrumbs.metadata.json and everything is working but i dont know if it is enough or if there are any other solution.

Thanks by advanced

@peterbsmyth
Copy link
Owner

@jpargana we are having the same issue now. and we are working on it. will keep you posted today.

@peterbsmyth
Copy link
Owner

@jpargana we incorporated your suggestion so the latest ngx-breadcrumbs-ui (0.0.10) ought to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants