-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conda-forge numpy to fix Win+py311 issues #12
Conversation
Hi @petercorke - please take a look and let me know what you think. A drawback of this approach is that the list of dependencies needs to be manually kept in sync between the pyproject.toml and the workflow file; but otherwise it should be nice and neat. I've also dropped Python 3.8 - it's nearly end-of-life and not well supported in conda-forge anymore. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 29.54% 28.85% -0.70%
==========================================
Files 34 34
Lines 7371 7371
==========================================
- Hits 2178 2127 -51
- Misses 5193 5244 +51 ☔ View full report in Codecov by Sentry. |
This works and is now merged. I'm concerned that that this action is now: (i) complex and fragile with respect to dependencies, (ii) doesn't use the toml file which should be the only source of truth, (iii) different to the actions in other projects. All of which gives me a dependency on you for ever :) |
Let's see whether this is the proper fix