Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda-forge numpy to fix Win+py311 issues #12

Merged
merged 24 commits into from
Dec 9, 2024

Conversation

Tobias-Fischer
Copy link
Contributor

Let's see whether this is the proper fix

@Tobias-Fischer
Copy link
Contributor Author

Hi @petercorke - please take a look and let me know what you think. A drawback of this approach is that the list of dependencies needs to be manually kept in sync between the pyproject.toml and the workflow file; but otherwise it should be nice and neat. I've also dropped Python 3.8 - it's nearly end-of-life and not well supported in conda-forge anymore.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.85%. Comparing base (cd25f59) to head (0099af8).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   29.54%   28.85%   -0.70%     
==========================================
  Files          34       34              
  Lines        7371     7371              
==========================================
- Hits         2178     2127      -51     
- Misses       5193     5244      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petercorke petercorke merged commit ddcc26d into petercorke:master Dec 9, 2024
13 checks passed
@Tobias-Fischer Tobias-Fischer deleted the patch-3 branch December 9, 2024 21:22
@petercorke
Copy link
Owner

This works and is now merged. I'm concerned that that this action is now: (i) complex and fragile with respect to dependencies, (ii) doesn't use the toml file which should be the only source of truth, (iii) different to the actions in other projects. All of which gives me a dependency on you for ever :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants