Performance improvement: if units are the same, no conversion is need…

…ed to compare
petermorlion · May 11, 2016 · d2e2b10 · d2e2b10
1 parent 28de41f
commit d2e2b10
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/RedStar.Amounts/Amount.cs b/RedStar.Amounts/Amount.cs
@@ -380,6 +380,11 @@ public Amount Power(int power)
         /// </summary>
         public static bool operator <(Amount left, Amount right)
         {
+            if (left.Unit == right.Unit)
+            {
+                return (left != right) && (left._value < right._value);
+            }
+
             var rightConverted = right.ConvertedTo(left._unit);
             return (left != rightConverted) && (left._value < rightConverted._value);
         }
@@ -389,6 +394,11 @@ public Amount Power(int power)
         /// </summary>
         public static bool operator <=(Amount left, Amount right)
         {
+            if (left.Unit == right.Unit)
+            {
+                return (left == right) || (left._value < right._value);
+            }
+
             var rightConverted = right.ConvertedTo(left._unit);
             return (left == rightConverted) || (left._value < rightConverted._value);
         }
@@ -398,6 +408,11 @@ public Amount Power(int power)
         /// </summary>
         public static bool operator >(Amount left, Amount right)
         {
+            if (left.Unit == right.Unit)
+            {
+                return (left != right) && (left._value > right._value);
+            }
+
             var rightConverted = right.ConvertedTo(left._unit);
             return (left != rightConverted) && (left._value > rightConverted._value);
         }
@@ -407,6 +422,11 @@ public Amount Power(int power)
         /// </summary>
         public static bool operator >=(Amount left, Amount right)
         {
+            if (left.Unit == right.Unit)
+            {
+                return (left == right) || (left._value > right._value);
+            }
+
             var rightConverted = right.ConvertedTo(left._unit);
             return (left == rightConverted) || (left._value > rightConverted._value);
         }