Add a todo for future callback changes

peternewman · Mar 25, 2024 · baf60c9 · baf60c9
1 parent f0b01b3
commit baf60c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/libs/acn/LLRPProbeRequestInflator.cpp b/libs/acn/LLRPProbeRequestInflator.cpp
@@ -103,14 +103,12 @@ bool LLRPProbeRequestInflator::HandlePDUData(uint32_t vector,
   OLA_DEBUG << "Probe from " << UID(pdu_data.lower_uid) << " to "
             << UID(pdu_data.upper_uid);
 
-//  string rdm_message(reinterpret_cast<const char*>(&data[0]), pdu_len);
-
   if (m_llrp_probe_request_handler.get()) {
     m_llrp_probe_request_handler->Run(&headers,
                                       UID(pdu_data.lower_uid),
                                       UID(pdu_data.upper_uid)
-//,
-//                                      UIDSet()
+// TODO(Peter): Should we add the filter and known UIDs to the callback too?
+//,                                      UIDSet()
 );
   } else {
     OLA_WARN << "No LLRP Probe Request handler defined!";

diff --git a/libs/acn/LLRPProbeRequestInflator.h b/libs/acn/LLRPProbeRequestInflator.h
@@ -39,8 +39,8 @@ class LLRPProbeRequestInflator: public BaseInflator {
                          const HeaderSet*,  // the HeaderSet
                          const ola::rdm::UID&,  // lower UID
                          const ola::rdm::UID&  // upper UID
-//,
-//                         const ola::rdm::UIDSet,  // known UIDs
+// TODO(Peter): Should we add the filter and known UIDs to the callback too?
+//,                         const ola::rdm::UIDSet,  // known UIDs
                         > LLRPProbeRequestHandler;
 
   LLRPProbeRequestInflator();