Fix support for CPython development releases. #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a long-standing bug handling development versions of CPython (any non-tagged release of the interpreter). These interpreters report a full version of `X.Y.Z+` and the trailing `+` leads to a non PEP-440 compliant version number. This, in turn, causes issues with the `packaging` library leading to failures to evaluate markers for these interpreters which surface as inscrutable Pex errors. Apply the same workaround as used in packaging >= 24.1. See: + pypa/packaging#802 + pypa/packaging#825
|
@cburroughs you're on here since this fixes pantsbuild/pants#21851 which you had some interaction with. |
jsirois
commented
Jan 30, 2025
| # + https://github.com/pypa/packaging/pull/802 | ||
| # + https://github.com/pypa/packaging/pull/825 | ||
| # | ||
| # N.B.: We can't simply upgrade to packaging >= 24.1 since those changes unconditionally access |
There was a problem hiding this comment.
|
I'm going to push this through and get out a release. |
Thanks! PR to update Pants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a long-standing bug handling development versions of CPython (any
non-tagged release of the interpreter). These interpreters report a full
version of
X.Y.Z+and the trailing+leads to a non PEP-440compliant version number. This, in turn, causes issues with the
packaginglibrary leading to failures to evaluate markers for theseinterpreters which surface as inscrutable Pex errors.
Apply the same workaround as used in packaging >= 24.1. See: