Fix dup requirement extra merging during PEX boot. #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, using root requirements of `foo[bar] foo[baz]` would produce the same PEX as `foo[bar,baz]`, but the former PEX would not properly activate both the `bar` and `baz` extras during boot. This is now fixed. Fixes pex-tool#2706.
jsirois
commented
Feb 27, 2025
| ).assert_success() | ||
|
|
||
| installed_wheel_dir = CacheDir.INSTALLED_WHEELS.path(pex_root=pex_root) | ||
| for module in "foo", "bar", "baz": |
There was a problem hiding this comment.
N.B.: The import baz fails when the yield qualified_requirement.with_extras(...) in the fix above is reverted to just be the old yield qualified_requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using root requirements of
foo[bar] foo[baz]would producethe same PEX as
foo[bar,baz], (save for the root requirements list)but the former PEX would not properly activate both the
barandbazextras during boot. This is now fixed.
Fixes #2706.