-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add GitHub Actions job to publish the package #31
Conversation
- name: create a distribution | ||
run: | | ||
pip3 install build wheel | ||
python3 -m build --wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinion about this. (Either is fine for me)
(MEMO) Workflow filename (.github/workflows/publish.yml) is consistent with the registered one. |
Don't we need to set the PyPI repository url as well?
|
How about testing using TestPyPI, just in case? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me
Created the action job to automate the publish pipeline based on https://github.com/pypa/gh-action-pypi-publish.