Fixing some problems detected with clang-tidy

include/c_types/trsp/trsp.h

@@ -33,21 +33,20 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #ifdef __cplusplus
 #   include <cstdint>
 typedef int64_t int64;
-typedef double float8;
 #else
 #   include <stdint.h>
 #endif
 
 struct restrict_t {
     int target_id;
-    float8 to_cost;
+    double to_cost;
     int via[MAX_RULE_LENGTH];
 };
 
 struct path_element_tt {
-    int64 vertex_id;
-    int64 edge_id;
-    float8 cost;
+    int64_t vertex_id;
+    int64_t edge_id;
+    double cost;
 };
 
 

include/coloring/pgr_bipartite_driver.hpp

@@ -45,6 +45,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include "cpp_common/pgr_messages.hpp"
 #include "cpp_common/interruption.hpp"
 typedef struct II_t_rt II_t_rt;
+#include "c_types/ii_t_rt.h"
 
 namespace pgrouting {
 namespace functions {
@@ -78,7 +79,7 @@ class Pgr_Bipartite : public pgrouting::Pgr_messages {
                     int64_t vid = graph[*v].id;
                     boost::get(partition_map, *v) ==
                         boost::color_traits <boost::default_color_type>::white() ?
-                        results.push_back({{vid}, {0}}) :results.push_back({{vid}, {1}});
+                        results.push_back({{vid}, {0}}) : results.push_back({{vid}, {1}});
                 }
                 return results;
             }

include/contraction/pgr_deadEndContraction.hpp

@@ -35,6 +35,9 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include <queue>
 #include <functional>
 #include <vector>
+
+#include <boost/graph/adjacency_list.hpp>
+
 #include "cpp_common/identifiers.hpp"
 #include "cpp_common/interruption.hpp"
 

include/contraction/pgr_linearContraction.hpp

@@ -38,7 +38,9 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 #include <boost/graph/iteration_macros.hpp>
 #include <boost/graph/filtered_graph.hpp>
+#include <boost/graph/adjacency_list.hpp>
 
+#include "cpp_common/ch_edge.hpp"
 #include "cpp_common/identifiers.hpp"
 
 

include/cpp_common/basePath_SSEC.hpp

@@ -90,7 +90,7 @@ class Path {
     ConstpthIt end() const {return path.end();}
 
 
-    void erase(pthIt pos) {path.erase(pos);}
+    void erase(const pthIt &pos) {path.erase(pos);}
     const Path_t& back() const {return path.back();}
     Path_t& back() {return path.back();}
     const Path_t& front() const {return path.front();}

include/cpp_common/bline.hpp

@@ -31,6 +31,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_BLINE_HPP_
 #pragma once
 
+#include <boost/geometry.hpp>
 #include <boost/geometry/geometries/multi_point.hpp>
 #include <boost/geometry/geometries/linestring.hpp>
 #include <boost/geometry/geometries/multi_linestring.hpp>

include/cpp_common/coordinate_t.hpp

@@ -30,12 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_COORDINATE_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
 
 struct Coordinate_t {
     int64_t id;

include/cpp_common/costFlow_t.hpp

@@ -27,13 +27,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_COSTFLOW_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
-
+#include <cstdint>
 
 struct CostFlow_t {
   int64_t edge_id;

include/cpp_common/delauny_t.hpp

@@ -30,12 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_DELAUNY_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
 
 struct Delauny_t {
     int64_t tid;

include/cpp_common/edge_t.hpp

@@ -30,12 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_EDGE_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
 
 struct Edge_t{
     int64_t id;

include/cpp_common/edge_xy_t.hpp

@@ -30,13 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_EDGE_XY_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
-
+#include <cstdint>
 
 struct Edge_xy_t {
     int64_t id;

include/cpp_common/orders_t.hpp

@@ -30,19 +30,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_PICKDELIVER_ORDERS_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
 
-/**************************************************************************
- * pickDelivery types
- * ***********************************************************************/
-/*
- * its with either (foo_x, foo_y) pairs (for euclidean or with foo_node_id (for matrix)
- */
 struct Orders_t {
     int64_t id;
     double demand;

include/cpp_common/point_on_edge_t.hpp

@@ -30,12 +30,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_POINT_ON_EDGE_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
 
 struct Point_on_edge_t {
     int64_t pid;

include/cpp_common/restriction_t.hpp

@@ -30,12 +30,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_RESTRICTION_T_HPP_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
+#include <cstdint>
+#include <cstddef>
 
 struct Restriction_t {
     double cost;

include/cpp_common/vehicle_t.hpp

@@ -30,16 +30,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_CPP_COMMON_VEHICLE_T_H_
 #pragma once
 
-/* for int64_t */
-#ifdef __cplusplus
-#   include <cstdint>
-#else
-#   include <stdint.h>
-#endif
-
-/*
- * its with either (foo_x, foo_y) pairs for euclidean or with foo_node_id (for matrix)
- */
+#include <cstdint>
+
 struct  Vehicle_t {
     int64_t id;
     double capacity;

include/dominator/pgr_lengauerTarjanDominatorTree_driver.hpp

@@ -44,6 +44,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include "cpp_common/interruption.hpp"
 #include "cpp_common/pgr_messages.hpp"
 #include "cpp_common/pgr_base_graph.hpp"
+#include "c_types/ii_t_rt.h"
 
 
 namespace pgrouting {

include/drivers/allpairs/floydWarshall_driver.h

@@ -37,6 +37,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 using IID_t_rt = struct IID_t_rt;
 #else
 #   include <stddef.h>
+#include <stdbool.h>
 typedef struct IID_t_rt IID_t_rt;
 #endif
 

include/drivers/allpairs/johnson_driver.h

@@ -36,6 +36,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 using IID_t_rt = struct IID_t_rt;
 #else
 #   include <stddef.h>
+#include <stdbool.h>
 typedef struct IID_t_rt IID_t_rt;
 #endif
 

include/drivers/chinese/chinesePostman_driver.h

@@ -36,6 +36,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 using Path_rt = struct Path_rt;
 #else
 #   include <stddef.h>
+#include <stdbool.h>
 typedef struct Path_rt Path_rt;
 #endif
 

include/drivers/lineGraph/lineGraphFull_driver.h

@@ -34,11 +34,9 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 /* for size-t */
 #ifdef __cplusplus
 #   include <cstddef>
-using Edge_t = struct Edge_t;
 using Line_graph_full_rt = struct Line_graph_full_rt;
 #else
 #   include <stddef.h>
-typedef struct Edge_t Edge_t;
 typedef struct Line_graph_full_rt Line_graph_full_rt;
 #endif
 

include/drivers/lineGraph/lineGraph_driver.h

@@ -37,6 +37,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 using Edge_rt = struct Edge_rt;
 #else
 #   include <stddef.h>
+#include <stdbool.h>
 typedef struct Edge_rt Edge_rt;
 #endif
 

include/drivers/max_flow/maximum_cardinality_matching_driver.h

@@ -31,11 +31,12 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_DRIVERS_MAX_FLOW_MAXIMUM_CARDINALITY_MATCHING_DRIVER_H_
 #pragma once
 
-#include <stddef.h>
-
 #ifdef __cplusplus
+#include <cstddef>
 using Only_int_rt = struct Only_int_rt;
 #else
+#include <stddef.h>
+#include <stdbool.h>
 typedef struct Only_int_rt Only_int_rt;
 #endif
 

include/drivers/planar/isPlanar_driver.h

@@ -31,10 +31,8 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_DRIVERS_PLANAR_ISPLANAR_DRIVER_H_
 #pragma once
 
-#ifdef __cplusplus
-#   include <cstddef>
-#else
-#   include <stddef.h>
+#ifndef __cplusplus
+#include <stdbool.h>
 #endif
 
 #ifdef __cplusplus

include/drivers/trsp/trsp_core.h

@@ -32,6 +32,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #else
 #   include <stddef.h>
 #   include <stdint.h>
+#include <stdbool.h>
 #endif
 
 typedef struct restrict_t restrict_t;

include/drivers/tsp/TSP_driver.h

@@ -40,6 +40,7 @@ using TSP_tour_rt = struct TSP_tour_rt;
 #else
 #   include <stddef.h>
 #   include <stdint.h>
+#include <stdbool.h>
 typedef struct TSP_tour_rt TSP_tour_rt;
 #endif
 

include/drivers/tsp/euclideanTSP_driver.h

@@ -40,6 +40,7 @@ using TSP_tour_rt = struct TSP_tour_rt;
 #   include <stddef.h>
 #   include <stdint.h>
 typedef struct TSP_tour_rt TSP_tour_rt;
+#include <stdbool.h>
 #endif
 
 #ifdef __cplusplus

include/drivers/yen/turnRestrictedPath_driver.h

@@ -39,6 +39,7 @@ using Path_rt = struct Path_rt;
 #else
 #   include <stddef.h>
 #   include <stdint.h>
+#include <stdbool.h>
 typedef struct Path_rt Path_rt;
 #endif
 

include/visitors/dijkstra_visitors.hpp

@@ -35,6 +35,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include <set>
 #include <vector>
 #include "visitors/found_goals.hpp"
+#include "cpp_common/pgr_assert.hpp"
 
 namespace pgrouting {
 namespace visitors {

include/vrp/optimize.hpp

@@ -28,14 +28,12 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #define INCLUDE_VRP_OPTIMIZE_HPP_
 #pragma once
 
-#include "vrp/optimize.hpp"
+#include "vrp/solution.hpp"
+#include "vrp/pgr_pickDeliver.hpp"
 
 namespace pgrouting {
 namespace vrp {
 
-class Solution;
-class Pgr_pickDeliver;
-
 
 class Optimize : public Solution {
  public:

include/vrp/pd_orders.hpp

@@ -36,14 +36,13 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #include "cpp_common/identifiers.hpp"
 
 #include "vrp/pd_problem.hpp"
+#include "vrp/order.hpp"
+#include "vrp/vehicle_node.hpp"
 
 
 namespace pgrouting {
 namespace vrp {
 
-class Order;
-class Vehicle_node;
-
 class PD_Orders {
     /** PD_rpblem needs access to set up the problem pointer */
      friend class PD_problem;

src/driving_distance/many_to_dist_driving_distance.c

@@ -48,7 +48,7 @@ static
 void process(
         char* edges_sql,
         ArrayType *starts,
-        float8 distance,
+        double distance,
         bool directed,
         bool equicost,
         MST_rt **result_tuples,