[GSoC 2023] Modifying withPointsKSP #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added capability to include new result columns * added new function for YEN's algorithm * used algorithms as namesapce
added include statement for new function in basePath_SSEC.hpp
* Handling old & new code * Removing unnecesary comments * [C++] Calling function to get new results column * [C] Creating internal function _pgr_v4withpointsksp for new signature * [C] Changing the evaluation on the driving side * if graph is directed then valid values are [R, L, r, l], * else valid values are [B, b]
Created a new function to handle it
* Changing driving side from optional to compulsory param * Including new columns in the output of single vertex overload and new overloads * Updating v3.6 signature file * Passing update test
… and release notes
AbhinJ
requested review from
cvvergara,
krashish8,
robe2,
omshinde and
shobhit162
shobhit162
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
The PR looks good to me.
Thanks @AbhinJ for your contribution!
robe2
approved these changes
Aug 22, 2023
krashish8
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies one existing function:
pgr_withPointsKSP:This is a final merge PR containing commits from several different PRs combined.
The intermediate PRs made on the GSoC-pgRouting repository are as follows:
The wiki page with more details on this project can be found here.