Fixed issues reported in #7958 #7959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asheshv
commented
Sep 23, 2024
asheshv
commented
- Search wasn't working as we were using wrong row-index, while rendering it.
- Fixed the CSS issue with the alignment of the search input box.
- Pass the row object while rendering the 'DataRow' component, to improve the performance as it was calling the filtering function repeatedly for each row.
- Changed the order of the validators on a field to priortize the 'empty' string validator over the unique-id validator in a collection.
- Search wasn't working as we were using wrong row-index, while rendering it. - Fixed the CSS issue with the alignment of the search input box. - Pass the row object while rendering the 'DataRow' component, to improve the performance as it was calling the filtering function repeatedly for each row. - Changed the order of the validators on a field to priortize the 'empty' string validator over the unique-id validator in a collection.
asheshv
changed the title
|
The search box result is wrong. Expected search box width Current search box width |
It is not a side effect or bug, but - It has been changed like that intentionally. |
|
The search box result is correctly displayed. One remaining issue still not fixed i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.