Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump ruby from 3.4-alpine to 3.4.2-alpine in /containers/docker #3092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⬆️ Bump ruby from 3.4-alpine to 3.4.2-alpine in /containers/docker #3092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions containers/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
ARG BUNDLE_WITHOUT=development:test
ARG BUNDLE_DEPLOYMENT=true

FROM ruby:3.4-alpine AS build-env
FROM ruby:3.4.2-alpine AS build-env

# include global args
ARG BUNDLE_WITHOUT
Expand Down Expand Up @@ -60,7 +60,7 @@
# bundle exec rails secret
# 2. Set the secret_key_base in your environment:
# SECRET_KEY_BASE=<value>
ENV SECRET_KEY_BASE=783ff1544b9612d8bceb8e26a0bab0cf22543eec658a498e7ef9e1d617976f960092005c8a54cb588759dc6dd8fd054bc4eca4a94dd7b96c6efda4a14a01bfbd

Check warning on line 63 in containers/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / pwpush-container

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "SECRET_KEY_BASE")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

# Precompile bootsnap cache for gems an application code to improve load time
# This creates a cache of the gem requires and application code which speeds up application boot
Expand All @@ -72,7 +72,7 @@

################## Build done ##################

FROM ruby:3.4-alpine
FROM ruby:3.4.2-alpine

# include global args
ARG BUNDLE_WITHOUT
Expand Down Expand Up @@ -112,7 +112,7 @@
# bundle exec rails secret
# 2. Set the secret_key_base in your environment:
# SECRET_KEY_BASE=<value>
ENV SECRET_KEY_BASE=783ff1544b9612d8bceb8e26a0bab0cf22543eec658a498e7ef9e1d617976f960092005c8a54cb588759dc6dd8fd054bc4eca4a94dd7b96c6efda4a14a01bfbd

Check warning on line 115 in containers/docker/Dockerfile

View workflow job for this annotation

GitHub Actions / pwpush-container

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "SECRET_KEY_BASE")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

COPY --from=build-env --chown=pwpusher:pwpusher ${APP_ROOT} ${APP_ROOT}

Expand Down
Loading