fix shadow ray regression

pgrit · Mar 8, 2024 · f76c313 · f76c313
1 parent eb624d9
commit f76c313
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/Core/scene.cpp b/Core/scene.cpp
@@ -83,8 +83,9 @@ bool Scene::IsOccluded(const Ray& ray, float maxDistance) {
     rtcray.dir_z = ray.direction.z;
     rtcray.tnear = ray.minDistance;
     rtcray.tfar = maxDistance;
-    rtcray.mask = 0;
+    rtcray.mask = 1;
     rtcray.flags = 0;
+    rtcray.time = 0;
 
     rtcOccluded1(embreeScene, &rtcray);
 

diff --git a/TinyEmbree.Tests/Raytracer_Simple.cs b/TinyEmbree.Tests/Raytracer_Simple.cs
@@ -38,6 +38,45 @@ public void SimpleQuad_ShouldBeIntersected() {
             Assert.Equal(1u, rt.Stats.NumRayHits);
         }
 
+        [Fact]
+        public void SimpleQuad_ShadowRay() {
+
+            var vertices = new Vector3[] {
+                new Vector3(-1, 0, -1),
+                new Vector3( 1, 0, -1),
+                new Vector3( 1, 0,  1),
+                new Vector3(-1, 0,  1)
+            };
+
+            var indices = new int[] {
+                0, 1, 2,
+                0, 2, 3
+            };
+
+            TriangleMesh mesh = new(vertices, indices);
+
+            using var rt = new Raytracer();
+            rt.AddMesh(mesh);
+            rt.CommitScene();
+
+            Hit a = new() {
+                Position = new Vector3(-0.5f, -10, 0),
+            };
+
+            Hit b = new() {
+                Position = new Vector3(-0.5f, 10, 0),
+            };
+
+            Hit c = new() {
+                Position = new Vector3(-0.5f, -20, 0),
+            };
+
+            Assert.True(rt.IsOccluded(a, b));
+            Assert.True(rt.IsOccluded(b, a));
+            Assert.True(!rt.IsOccluded(a, c));
+            Assert.True(!rt.IsOccluded(c, a));
+        }
+
         [Fact]
         public void SimpleQuad_ShouldBeMissed() {
             var vertices = new Vector3[] {