Scaffold the build interface #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Builder` struct defines the public interface for building a PGXN release. Internally, it delegates `configure`, `compile`, and `test` commands (so far) to pipeline-specific build modules. Its `new` constructor reads the pgxn_meta Release pipeline to determine which one to instantiate; in the future it will also fall back on detecting the pipeline where none is specified. The `error` module define errors returned by the crate, while the `pipeline` module defines a trait with the functions `Builder` expects to dispatch to. All pipelines must implement this trait. This will make it easy to add new pipelines in the future; They just have to implement the trait, add a new `Build` enum, then add appropriate calls to its methods in `Builder`'s dispatching methods. For now, the `pgxs` and `pgrx` modules alone define structs that implement the `pipeline.Pipeline` trait with no-op functions. Add tests for basic functionality of `Builder`.
vrmiguel
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Builderstruct defines the public interface for building a PGXN release. Internally, it delegatesconfigure,compile, andtestcommands (so far) to pipeline-specific build modules. Itsnewconstructor reads the pgxn_meta Release pipeline to determine which one to instantiate; in the future it will also fall back on detecting the pipeline where none is specified.The
errormodule define errors returned by the crate, while thepipelinemodule defines a trait with the functionsBuilderexpects to dispatch to. All pipelines must implement this trait. This will make it easy to add new pipelines in the future; They just have to implement the trait, add a newBuildenum, then add appropriate calls to its methods inBuilder's dispatching methods.For now, the
pgxsandpgrxmodules alone define structs that implement thepipeline.Pipelinetrait with no-op functions.Add tests for basic functionality of
Builder.