Tests: Flake fixes (#709)

* chore: remove capybara-lockstep as it was incompatible with cuprite and doing nothing, update other gems

* chore: fix some flakes with group links tests

* chore: fix flakes in submission job test

* chore: disable parallelization in CI and increase ferrum GOTO_WAIT

* chore: reenable test parallelization in CI

* chore: fix components which used Ransack::Helpers::FormHelper

* chore: remove click_button from axe_helpers and add assert_accesible after click_button where page state is expected to change and component is not tested separately

* chore: increase FERRUM_GOTO_WAIT to 0.4 seconds from 0.2

* chore: fix some more flaky tests

* chore: fix typo

* chore: fix another typo

* chore: fix some flaky jobs tests

* chore: fix some flaky tests where dialog might still be open before updated page is checked

* chore: bump FERRUM_GOTO_WAIT to 0.8 from 0.6

* chore: update nextflow_component to close dialog when turbo submit finishes

* chore: fix flaky tests by removing usage of within(first( and just use within with appropriate selectors

* chore: remove FERRUM_GOTO_WAIT and increase page load timeout to 45seconds

.github/workflows/ruby.yml

@@ -19,7 +19,6 @@ jobs:
           POSTGRES_PASSWORD: test
           POSTGRES_USER: test
           POSTGRES_HOST: postgres
-          FERRUM_GOTO_WAIT: 0.8 # wait 0.8 seconds before checking if network traffic is still pending
         ports:
           - 5432:5432
         # Set health checks to wait until postgres has started
@@ -60,7 +59,7 @@ jobs:
         if: failure()
         with:
           name: screenshots
-          path: ${{ github.workspace }}/tmp/screenshots
+          path: ${{ github.workspace }}/tmp/capybara/screenshots
           if-no-files-found: ignore
       - name: Report coverage
         if: github.event_name == 'pull_request'

Gemfile

@@ -161,7 +161,6 @@ end
 group :test do
   # Use system testing [https://guides.rubyonrails.org/testing.html#system-testing]
   gem 'capybara'
-  gem 'capybara-lockstep'
   gem 'cuprite'
 
   gem 'simplecov', require: false
@@ -171,3 +170,6 @@ group :test do
 end
 
 gem 'activerecord-session_store', '~> 2.1'
+
+# TODO: upgrade to 5.25.1 once released: https://github.com/minitest/minitest/issues/1007
+gem 'minitest', '5.24.1'