Refactor: Bots System Tests (#891)

* start fixing bots test, fix dialog ids when multiple dialogs present * finish refactori bots tests * add additional asserts in samples_test
phac-nml · Jan 13, 2025 · a6a42bf · a6a42bf
1 parent 9c15cbf
commit a6a42bf
Show file tree

Hide file tree

Showing 7 changed files with 327 additions and 122 deletions.
diff --git a/app/views/groups/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb b/app/views/groups/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb
@@ -1,4 +1,4 @@
-<%= viral_dialog(open: open, size: :extra_large) do |dialog| %>
+<%= viral_dialog(open: open, id: 'bot_tokens_dialog', size: :extra_large) do |dialog| %>
   <%= dialog.with_header(
     title: t("groups.bots.index.personal_access_tokens_listing_modal.title"),
   ) %>

diff --git a/app/views/groups/bots/personal_access_tokens/_revoke_confirmation_modal.html.erb b/app/views/groups/bots/personal_access_tokens/_revoke_confirmation_modal.html.erb
@@ -1,4 +1,4 @@
-<%= viral_dialog(open: open) do |dialog| %>
+<%= viral_dialog(open: open, id: 'revoke_confirmation_dialog') do |dialog| %>
   <%= dialog.with_header(title: t("personal_access_tokens.revoke_confirmation.title")) %>
   <%= dialog.with_section do %>
 

diff --git a/app/views/projects/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb b/app/views/projects/bots/personal_access_tokens/_personal_access_token_listing_modal.html.erb
@@ -1,4 +1,4 @@
-<%= viral_dialog(open: open, size: :extra_large) do |dialog| %>
+<%= viral_dialog(open: open, id: 'bot_tokens_dialog', size: :extra_large) do |dialog| %>
   <%= dialog.with_header(
     title: t("projects.bots.index.personal_access_tokens_listing_modal.title"),
   ) %>

diff --git a/app/views/projects/bots/personal_access_tokens/_revoke_confirmation_modal.html.erb b/app/views/projects/bots/personal_access_tokens/_revoke_confirmation_modal.html.erb
@@ -1,4 +1,4 @@
-<%= viral_dialog(open: open) do |dialog| %>
+<%= viral_dialog(open: open, id: 'revoke_confirmation_dialog') do |dialog| %>
   <%= dialog.with_header(title: t("personal_access_tokens.revoke_confirmation.title")) %>
   <%= dialog.with_section do %>