Submit search on enter

[joshsadam]

What does this PR do and why?

Describe in detail what your merge request does and why.

1. Standardized Search Component
2. Search now works when the enter key is pressed, not debounced

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Ensure that search still works across the project (tested through our integration tests as well)

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the PR acceptance checklist for this PR.

[ChrisHuynh333]

Just through usage on the website, I noticed a few inconsistencies. This is assuming we want the search field to still be populated with the search after hitting enter, and to have focus on the search bar. As well as after leaving the page, the filter would be removed

• Projects dashboard - Search field is emptied and not focused after search
• Groups dashboard - If I leave the groups dashboard page and come back, the search bar is still populated with the search but the groups are not filtered
• Data Exports - Search field is emptied and not focused after search
• Samples - Search and filter are still enabled after leaving and coming back to the page
• Project Files - Search field is emptied and not focused after search

I also think if the user clicks on the "X" at the end of the search bar, that should return an unfiltered request, thoughts?

[ericenns]

Just through usage on the website, I noticed a few inconsistencies. This is assuming we want the search field to still be populated with the search after hitting enter, and to have focus on the search bar. As well as after leaving the page, the filter would be removed

• Projects dashboard - Search field is emptied and not focused after search
• Groups dashboard - If I leave the groups dashboard page and come back, the search bar is still populated with the search but the groups are not filtered
• Data Exports - Search field is emptied and not focused after search
• Samples - Search and filter are still enabled after leaving and coming back to the page
• Project Files - Search field is emptied and not focused after search

I also think if the user clicks on the "X" at the end of the search bar, that should return an unfiltered request, thoughts?

Samples table search is expected to be different as we store that server side, but I agree with your remaining comments.

[joshsadam]

@ChrisHuynh333 & @ericenns Those pages are updated along with tests

[github-actions]

Code Metrics Report

Coverage	Test Execution Time
93.3%	8m28s

Code coverage of files in pull request scope (99.4%)

Files	Coverage
app/components/list_filter_component.html.erb	100.0%
app/components/ransack/hidden_sort_field_component.rb	100.0%
app/components/search_component.html.erb	100.0%
app/components/search_component.rb	100.0%
app/components/viral/tabs_component.html.erb	100.0%
app/components/viral/tabs_component.rb	100.0%
app/views/dashboard/groups/index.html.erb	100.0%
app/views/dashboard/projects/index.html.erb	100.0%
app/views/dashboard/projects/index.turbo_stream.erb	100.0%
app/views/data_exports/index.html.erb	100.0%
app/views/groups/attachments/index.html.erb	100.0%
app/views/groups/group_links/_invited_groups.html.erb	100.0%
app/views/groups/members/_member_listing.html.erb	100.0%
app/views/groups/members/index.html.erb	100.0%
app/views/groups/samples/index.html.erb	100.0%
app/views/groups/show.html.erb	92.8%
app/views/projects/attachments/index.html.erb	100.0%
app/views/projects/members/index.html.erb	100.0%
app/views/projects/samples/index.html.erb	100.0%

---

Reported by octocov

[ericenns]

Looks good to me!

Comments have been addressed, and I verified the changes