-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable automated pipelines #825
Conversation
25d8156
to
47b7fb7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2f2f748
to
0a2f74d
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as described!
0a2f74d
to
0f777e3
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected, but I did find an edge case that was not previously documented where a pipeline entry removed from the config file would still leave an automated pipeline as enabled if it was enabled prior to removing from the config file.
app/views/projects/automated_workflow_executions/_automated_workflow_execution.html.erb
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… executions table
…ble and exectuable
d9bf81e
to
81b688f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me just have one small comment
app/views/projects/automated_workflow_executions/_automated_workflow_execution.html.erb
Outdated
Show resolved
Hide resolved
Code Metrics Report
Code coverage of files in pull request scope (97.2%)Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
What does this PR do and why?
Added a new status column to the automated pipelines table to show if the pipeline is enabled/disabled.
Fixes #819.
Screenshots or screen recordings
How to set up and validate locally
"automatable": false
or"executable": false
or both or remove it entirely.PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.