Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automated pipelines #825

Merged
merged 23 commits into from
Nov 1, 2024
Merged

Disable automated pipelines #825

merged 23 commits into from
Nov 1, 2024

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Oct 18, 2024

What does this PR do and why?

Added a new status column to the automated pipelines table to show if the pipeline is enabled/disabled.
Fixes #819.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Create an automated workflow execution within a project.
  2. Remember the workflow name and version.
  3. Modify the pipeline within the config/pipelines/pipelines.json file with "automatable": false or "executable": false or both or remove it entirely.
  4. Restart irida-next.
  5. Navigate to the project automation workflow executions page.
  6. Verify the newly added automated workflow execution is disabled.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ksierks ksierks self-assigned this Oct 18, 2024
@ksierks ksierks force-pushed the disable-automated-pipelines branch from 25d8156 to 47b7fb7 Compare October 22, 2024 14:00

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ksierks ksierks requested a review from ericenns October 25, 2024 16:47
@ksierks ksierks marked this pull request as ready for review October 25, 2024 16:47
@ksierks ksierks force-pushed the disable-automated-pipelines branch from 2f2f748 to 0a2f74d Compare October 28, 2024 14:47

This comment has been minimized.

ChrisHuynh333
ChrisHuynh333 previously approved these changes Oct 28, 2024
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described!

This comment has been minimized.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected, but I did find an edge case that was not previously documented where a pipeline entry removed from the config file would still leave an automated pipeline as enabled if it was enabled prior to removing from the config file.

This comment has been minimized.

This comment has been minimized.

@ksierks ksierks force-pushed the disable-automated-pipelines branch from d9bf81e to 81b688f Compare October 30, 2024 19:53

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me just have one small comment

Copy link

github-actions bot commented Nov 1, 2024

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ericenns ericenns merged commit 4b40c22 into main Nov 1, 2024
3 checks passed
@ericenns ericenns deleted the disable-automated-pipelines branch November 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled automated pipelines
4 participants