Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Executions: Filter #826

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Workflow Executions: Filter #826

merged 8 commits into from
Nov 1, 2024

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Oct 18, 2024

What does this PR do and why?

This PR adds filtering to the user and project's workflow execution index pages

Screenshots or screen recordings

image

How to set up and validate locally

For both the user and project's workflow execution index pages:

  1. Create numerous workflow executions if necessary
  2. Use the filter and ensure it filters as expected (by ID and name)
  3. Ensure sort works in tandem with filter.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

This comment has been minimized.

@ChrisHuynh333 ChrisHuynh333 marked this pull request as ready for review October 18, 2024 21:04
@ChrisHuynh333 ChrisHuynh333 self-assigned this Oct 18, 2024
@ChrisHuynh333 ChrisHuynh333 added ready for review Pull request is ready for review on hold and removed ready for review Pull request is ready for review on hold labels Oct 18, 2024
malchua
malchua previously approved these changes Oct 24, 2024
Copy link
Contributor

@malchua malchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Worked with pagination too

@ericenns ericenns requested a review from joshsadam October 30, 2024 12:51
@joshsadam
Copy link
Contributor

Can you update the table to use the highlighter for the search term?

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just those two comments

@ChrisHuynh333 ChrisHuynh333 force-pushed the search-workflow-executions branch from 55a4515 to 5e9bec3 Compare October 31, 2024 15:45

This comment has been minimized.

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing here

test/fixtures/workflow_executions.yml Outdated Show resolved Hide resolved
@joshsadam joshsadam merged commit d316ba2 into main Nov 1, 2024
3 checks passed
@joshsadam joshsadam deleted the search-workflow-executions branch November 1, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants