Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Render flat list for groups when filtering #827

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Oct 22, 2024

What does this PR do and why?

This PR fixes a bug where the expected flat list when filtering for groups (on dashboard and subgroups/projects) was not rendering properly.

Screenshots or screen recordings

Before:
image

Now:
image

How to set up and validate locally

On both dashboard groups and groups subgroups and projects

  1. Use the search bar to filter down the list (filter with an overlapping name a group(s) and their subgroup(s)).
  2. Verify any groups that would have subgroups no longer has the dropdown to view its subgroups within, and that any subgroups that fit the filter are now listed.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ChrisHuynh333 ChrisHuynh333 marked this pull request as ready for review October 22, 2024 14:55

This comment has been minimized.

@ChrisHuynh333 ChrisHuynh333 self-assigned this Oct 22, 2024
@ChrisHuynh333 ChrisHuynh333 added the ready for review Pull request is ready for review label Oct 22, 2024
Copy link

Code Metrics Report

Coverage Test Execution Time
93.3% 8m10s

Code coverage of files in pull request scope (92.5%)

Files Coverage
app/controllers/dashboard/groups_controller.rb 100.0%
app/controllers/groups_controller.rb 89.3%
app/views/groups/subgroups/_index.html.erb 100.0%

Reported by octocov

@joshsadam joshsadam self-requested a review October 22, 2024 16:34
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for fixing the bug I introduced.

@joshsadam joshsadam requested a review from deepsidhu85 October 22, 2024 16:37
@ChrisHuynh333 ChrisHuynh333 mentioned this pull request Oct 24, 2024
1 task
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deepsidhu85 deepsidhu85 merged commit d097b0d into main Oct 24, 2024
3 checks passed
@deepsidhu85 deepsidhu85 deleted the fix-filtering-groups branch October 24, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants