Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Create database model for representing a Metadata Template #882

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Jan 7, 2025

What does this PR do and why?

Describe in detail what your merge request does and why.

Created the database model (and tests) for representing a Metadata Template

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

NONE

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

NONE

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@joshsadam joshsadam requested a review from deepsidhu85 January 7, 2025 17:39

This comment has been minimized.

This comment has been minimized.

@joshsadam joshsadam marked this pull request as ready for review January 7, 2025 20:40
@joshsadam joshsadam force-pushed the model/metdata-templates branch from 0028384 to 3c57fa7 Compare January 8, 2025 14:17

This comment has been minimized.

deepsidhu85
deepsidhu85 previously approved these changes Jan 8, 2025
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Was able to create a metadata template (only for a group or project) using rails console and can view the changes made to the metadata template via the log_data.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just one comment

app/models/metadata_template.rb Show resolved Hide resolved
Copy link

github-actions bot commented Jan 9, 2025

Code Metrics Report

Coverage Test Execution Time
92.9% 9m50s

Code coverage of files in pull request scope (98.5%)

Files Coverage
app/models/metadata_template.rb 94.1%
app/models/workflow_execution.rb 100.0%

Reported by octocov

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit 9f22766 into main Jan 9, 2025
4 checks passed
@ericenns ericenns deleted the model/metdata-templates branch January 9, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants