Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-end: Edit workflow execution name post launch #889

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

deepsidhu85
Copy link
Contributor

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR updates/adds to the back-end (policy, services, controller) to allow the submitter of a personal workflow execution to update the name of a workflow execution post launch, as well as, allows a user with access level ANALYST or higher to update the name of an automated workflow execution post launch.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Verify that the tests pass

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@deepsidhu85 deepsidhu85 self-assigned this Jan 8, 2025
@deepsidhu85 deepsidhu85 marked this pull request as ready for review January 8, 2025 18:59

This comment has been minimized.

This comment has been minimized.

ChrisHuynh333
ChrisHuynh333 previously approved these changes Jan 9, 2025
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise it looks good.

app/policies/workflow_execution_policy.rb Show resolved Hide resolved
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit a01a678 into main Jan 9, 2025
4 checks passed
@ericenns ericenns deleted the edit-workflow-exeuction branch January 9, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants