Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Edit workflow execution #893

Merged
merged 9 commits into from
Jan 16, 2025
Merged

UI: Edit workflow execution #893

merged 9 commits into from
Jan 16, 2025

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Jan 9, 2025

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds in the UI functionality to allow a submitter of a personal workflow execution to update the name of the workflow execution post launch, as well as, allows a user with access level ANALYST or higher to update the name of an automatically launched workflow execution post launch

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

Automated workflow execution:

image

image

image

image

image

image

Personal workflow execution:

image

image

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Test this out with a personal workflow execution (non-automated workflow execution launched from within a project) and with an automated workflow execution

Personal Workflow Execution:

  1. Create a project, a sample, and upload a paired-end dataset to the sample
  2. From the project -> samples page, select this sample and launch a pipeline (do not set a name)
  3. From the Workflow Executions page in the context of Your Work, click on the ID of the workflow execution which was just launched
  4. Verify there is no description list item for Name
  5. Click on the Edit button on the top right
  6. Add a new name and click Submit
  7. Verify that the name in the header is updated and that there is now a description list item for Name with the value you set the workflow execution name to
  8. Click Edit again, clear the name in the modal, and click Submit
  9. Verify the header has been updated to the workflow_execution -> metadata -> workflow_name and there is no longer a description list item for Name

Automated Workflow Execution

  1. Within the project above, setup an automated workflow execution from it's settings
  2. Add another member to this project with the access level ANALYST
  3. Add a new sample to the project, and upload a paired-end data set
  4. From the Workflow Executions page within the context of the project, click on the id of the latest launched workflow execution
  5. Follow steps 5 through 9 above (for the personal workflow execution), omitting verifying that the workflow execution name in the header as we display the id for an automated workflow execution
  6. Logout and login as the other member that you added whose access level is ANALYST
  7. Follow steps 5 through 9 above (for the personal workflow execution), omitting verifying that the workflow execution name in the header as we display the id for an automated workflow execution

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@deepsidhu85 deepsidhu85 marked this pull request as ready for review January 10, 2025 20:11
@deepsidhu85 deepsidhu85 self-assigned this Jan 10, 2025
@deepsidhu85 deepsidhu85 added the enhancement New feature or request label Jan 10, 2025
@ericenns ericenns requested a review from ksierks January 13, 2025 15:54
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple UI changs.  Feel free to chat with me about the dialogs.  I still need to go through your tests.

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I see on the tests

@deepsidhu85 deepsidhu85 force-pushed the edit-workflow-execution-ui branch from 10d06e2 to 4eaa404 Compare January 14, 2025 19:30
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit b96878e into main Jan 16, 2025
4 checks passed
@ericenns ericenns deleted the edit-workflow-execution-ui branch January 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants