-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Edit workflow execution #893
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple UI changs. Feel free to chat with me about the dialogs. I still need to go through your tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one thing I see on the tests
… own partial to fix display issue when clearing a workflow execution name. Fixed bug with header not being updated with the current name
…ummary with the updated values (done this way as adding a turbo_frame_tag inside of a dl causes accessibility issues)
10d06e2
to
4eaa404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR adds in the UI functionality to allow a submitter of a personal workflow execution to update the name of the workflow execution post launch, as well as, allows a user with access level
ANALYST
or higher to update the name of an automatically launched workflow execution post launchScreenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Automated workflow execution:
Personal workflow execution:
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Test this out with a personal workflow execution (non-automated workflow execution launched from within a project) and with an automated workflow execution
Personal Workflow Execution:
Workflow Executions
page in the context ofYour Work
, click on the ID of the workflow execution which was just launchedName
Edit
button on the top rightSubmit
Name
with the value you set the workflow execution name toEdit
again, clear the name in the modal, and clickSubmit
Name
Automated Workflow Execution
ANALYST
Workflow Executions
page within the context of the project, click on the id of the latest launched workflow executionANALYST
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.