Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #916

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Fix flaky tests #916

merged 5 commits into from
Jan 27, 2025

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Jan 26, 2025

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR fixes a bunch of flaky tests.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@deepsidhu85 deepsidhu85 self-assigned this Jan 26, 2025

This comment has been minimized.

This comment has been minimized.

Copy link

Code Metrics Report

Coverage Test Execution Time
92.6% 10m0s

Reported by octocov

@deepsidhu85 deepsidhu85 requested a review from ericenns January 26, 2025 20:27
@deepsidhu85 deepsidhu85 marked this pull request as ready for review January 26, 2025 20:27
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit 85fd404 into main Jan 27, 2025
4 checks passed
@ericenns ericenns deleted the fix-flaky-tests branch January 27, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants