Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker #162

Closed
wants to merge 2 commits into from
Closed

Add docker #162

wants to merge 2 commits into from

Conversation

Aeliot-Tm
Copy link
Contributor

I haven't had PHP installed locally for years. And I imagine there are many developers like me.
So, it would be nice to have this stuff here.

@Aeliot-Tm
Copy link
Contributor Author

Hi @theseer,

And this one please 😃

@Aeliot-Tm
Copy link
Contributor Author

Thanks in advance :)

@theseer
Copy link
Member

theseer commented Sep 9, 2024 •
edited
Loading

Sorry, not gonna merge this:

  • I personally dislike makefiles - this also has nothing to do with Docker
  • I understand the idea of having a container to run things in, but this setup is bloated like crazy. The two scripts you created (thanks!) merely require a basic xml aware PHP. No need for FPM, Compose and Xdebug.
  • If you really want, create a minimal Containerfile without all the bloat and I might merge it.

@theseer theseer closed this Sep 9, 2024
@Aeliot-Tm
Copy link
Contributor Author

Oh. I hear you.
What is about the debugging of scripts?
Could I leave xDebug, please? :)

@Aeliot-Tm
Copy link
Contributor Author

There is the smallest one #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aeliot-Tm @theseer