Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call glue::glue_sql() in dbSelect() and dbUpdate() #521

Merged
merged 18 commits into from
May 10, 2023
Merged

Conversation

Jeff-Thompson12
Copy link
Collaborator

Addresses #520

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #521 (310a427) into dev (3a2e97d) will increase coverage by 0.14%.
The diff coverage is 79.77%.

❗ Current head 310a427 differs from pull request most recent head c53c169. Consider uploading reports for the commit c53c169 to get more accurate results

@@            Coverage Diff             @@
##              dev     #521      +/-   ##
==========================================
+ Coverage   81.61%   81.75%   +0.14%     
==========================================
  Files          25       25              
  Lines        2964     2949      -15     
==========================================
- Hits         2419     2411       -8     
+ Misses        545      538       -7     
Impacted Files Coverage Δ
R/mod_decision_automation_utils.R 51.61% <0.00%> (ø)
R/mod_reportPreview.R 76.01% <0.00%> (+1.01%) ⬆️
R/mod_decision_automation.R 74.51% <50.00%> (ø)
R/utils_config_db.R 87.75% <50.00%> (ø)
R/utils_get_db.R 94.59% <95.23%> (-0.15%) ⬇️
R/mod_addComment.R 100.00% <100.00%> (ø)
R/mod_downloadHandler.R 64.96% <100.00%> (+2.54%) ⬆️
R/mod_reweightView.R 95.90% <100.00%> (-0.06%) ⬇️
R/mod_sidebar.R 95.91% <100.00%> (-0.09%) ⬇️
R/mod_uploadPackage.R 80.25% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merge branch 'dev' into jt-520-glue_sql

# Conflicts:
#	R/utils_insert_db.R
@Jeff-Thompson12 Jeff-Thompson12 marked this pull request as ready for review May 9, 2023 14:11
@Jeff-Thompson12
Copy link
Collaborator Author

NEWS and version number have not been updated yet but this is ready for a look.

Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All db activity appears to work for me in my testing. Would appreciate another pair of eyes taking a look though. Maybe @Robert-Krajcik or @imran3004? Thanks for the PR!

@Jeff-Thompson12
Copy link
Collaborator Author

Small edit to implement this new logic on the summary comments added with #512.

Also updated NEWS and version number.

Copy link
Contributor

@Robert-Krajcik Robert-Krajcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Jeff-Thompson12
In dbSelect() in utils_get_db.R I added
@importFrom glue glue glue_sql
and changed the two paste0() funcs to 'glue::glue() to be consistent with dbUpdate()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants