-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call glue::glue_sql()
in dbSelect()
and dbUpdate()
#521
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #521 +/- ##
==========================================
+ Coverage 81.61% 81.75% +0.14%
==========================================
Files 25 25
Lines 2964 2949 -15
==========================================
- Hits 2419 2411 -8
+ Misses 545 538 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merge branch 'dev' into jt-520-glue_sql # Conflicts: # R/utils_insert_db.R
NEWS and version number have not been updated yet but this is ready for a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All db activity appears to work for me in my testing. Would appreciate another pair of eyes taking a look though. Maybe @Robert-Krajcik or @imran3004? Thanks for the PR!
Small edit to implement this new logic on the summary comments added with #512. Also updated NEWS and version number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Jeff-Thompson12
In dbSelect()
in utils_get_db.R I added
@importFrom glue glue glue_sql
and changed the two paste0()
funcs to 'glue::glue()
to be consistent with dbUpdate()
Addresses #520