Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2231 added check in derive_vars_period() to remove unused columns #2245

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

manciniedoardo
Copy link
Collaborator

@manciniedoardo manciniedoardo commented Nov 18, 2023

Closes #2231

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link

github-actions bot commented Nov 18, 2023

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4596 / 4684)

@manciniedoardo
Copy link
Collaborator Author

manciniedoardo commented Nov 18, 2023

Issue was arising because derive_vars_period() does a lot of dynamic transposing/renaming with dataset_ref and when the latter contains variables not referenced anywhere in the function call, the transposing/renaming fails. Thus I added two lines of code to strip dataset_ref of any variables not relevant for the period derivation right at the start. I also added a test for this eventuality.

@manciniedoardo manciniedoardo requested a review from bms63 November 19, 2023 12:24
R/period_dataset.R Show resolved Hide resolved
@bms63 bms63 merged commit a3e50b2 into main Nov 21, 2023
17 of 18 checks passed
@bms63 bms63 deleted the 2231_derive_vars_period_unused_vars_bug branch November 21, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: derive_vars_period() errors unexpectedly when dataset_ref has unused variables
3 participants