Added comments

phax · Jan 9, 2024 · d53052c · d53052c
1 parent 186d034
commit d53052c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/...app/src/main/java/com/helger/phase4/peppol/server/servlet/Phase4PeppolWebAppListener.java b/...app/src/main/java/com/helger/phase4/peppol/server/servlet/Phase4PeppolWebAppListener.java
@@ -290,7 +290,8 @@ private static void _initPeppolAS4 ()
 
     // Check if the certificate is really a Peppol AP certificate - fail early
     // if something is misconfigured
-    // No CRL/OCSP check for performance
+    // * Do not cache result
+    // * Use the global checking mode or provide a new one
     final boolean bPerformOCSP = true;
     final EPeppolCertificateCheckResult eCheckResult = PeppolCertificateChecker.checkPeppolAPCertificate (aAPCert,
                                                                                                           MetaAS4Manager.getTimestampMgr ()

diff --git a/...rc/main/java/com/helger/phase4/peppol/servlet/Phase4PeppolServletMessageProcessorSPI.java b/...rc/main/java/com/helger/phase4/peppol/servlet/Phase4PeppolServletMessageProcessorSPI.java
@@ -604,9 +604,11 @@ public AS4MessageProcessorResult processAS4UserMessage (@Nonnull final IAS4Incom
 
     if (getCheckSigningCertificateRevocation ().getAsBooleanValue (Phase4PeppolServletConfiguration.isCheckSigningCertificateRevocation ()))
     {
-      // Check if signing certificate is revoked
       final OffsetDateTime aNow = MetaAS4Manager.getTimestampMgr ().getCurrentDateTime ();
       final X509Certificate aSenderCert = aState.getUsedCertificate ();
+      // Check if signing AP certificate is revoked
+      // * Use global caching setting
+      // * Use global certificate check mode
       final EPeppolCertificateCheckResult eCertCheckResult = PeppolCertificateChecker.checkPeppolAPCertificate (aSenderCert,
                                                                                                                 aNow,
                                                                                                                 ETriState.UNDEFINED,

diff --git a/...e4-spring-boot-demo/src/main/java/com/helger/phase4/springboot/servlet/ServletConfig.java b/...e4-spring-boot-demo/src/main/java/com/helger/phase4/springboot/servlet/ServletConfig.java
@@ -177,6 +177,9 @@ private static void _initPeppolAS4 ()
     // TODO This block SHOULD be uncommented once you have a Peppol certificate
     if (false)
     {
+      // Check that your Peppol AP certificate is valid
+      // * No caching
+      // * Use global certificate check mode
       final EPeppolCertificateCheckResult eCheckResult = PeppolCertificateChecker.checkPeppolAPCertificate (aAPCert,
                                                                                                             MetaAS4Manager.getTimestampMgr ()
                                                                                                                           .getCurrentDateTime (),