Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed "duplicated" ICryptoSessionKeyProvider instances for AES keys #294

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

beth-soptim
Copy link
Contributor

This basically reverts the change 90485ce.

AES keys for AES with CBC op mode and AES with GCM op mode are the same.

@phax
Copy link
Owner

phax commented Jan 6, 2025

Thanks, but we cannot simply delete existing constants. Please keep INSTANCE_RANDOM_AES_128_GCM and INSTANCE_RANDOM_AES_256_GCM in, but add a @Deprecated (forRemoval=true, since="3.0.2") annotation to both of them - thanks

@phax phax merged commit 5ab089a into phax:master Jan 6, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants