Skip to content

Commit

Permalink
Instrument titleText for a few instances, see phetsims/density#145
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Mar 24, 2023
1 parent 7f2c9ea commit e12a4b0
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion js/density/view/DensityCompareScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ export default class DensityCompareScreenView extends DensityBuoyancyScreenView<
children: [
new Text( DensityBuoyancyCommonStrings.blocksStringProperty, {
font: DensityBuoyancyCommonConstants.TITLE_FONT,
maxWidth: 160
maxWidth: 160,
tandem: blocksPanelTandem.createTandem( 'titleText' )
} ),
new VerticalAquaRadioButtonGroup( model.blockSetProperty, BlockSet.enumeration.values.map( blockSet => {
return {
Expand Down
3 changes: 2 additions & 1 deletion js/density/view/DensityIntroScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ export default class DensityIntroScreenView extends SecondaryMassScreenView<Dens
maxWidth: 200,
visiblePropertyOptions: {
phetioReadOnly: true
}
},
tandem: accordionTandem.createTandem( 'titleText' )
} ),
expandedProperty: model.densityExpandedProperty,
buttonAlign: 'left' as const,
Expand Down
6 changes: 4 additions & 2 deletions js/density/view/DensityMysteryScreenView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ export default class DensityMysteryScreenView extends DensityBuoyancyScreenView<
cameraLookAt: DensityBuoyancyCommonConstants.DENSITY_CAMERA_LOOK_AT
}, options ) );

const densityTableAccordionBoxTandem = tandem.createTandem( 'densityTableAccordionBox' );
const densityTableAccordionBox = new AccordionBox( new DensityTableNode(), combineOptions<AccordionBoxOptions>( {
titleNode: new Text( DensityBuoyancyCommonStrings.densityTableStringProperty, {
font: DensityBuoyancyCommonConstants.TITLE_FONT,
maxWidth: 200
maxWidth: 200,
tandem: densityTableAccordionBoxTandem.createTandem( 'titleText' )
} ),
expandedProperty: model.densityTableExpandedProperty,
tandem: tandem.createTandem( 'densityTableAccordionBox' )
tandem: densityTableAccordionBoxTandem
}, DensityBuoyancyCommonConstants.ACCORDION_BOX_OPTIONS ) );

this.addChild( new AlignBox( densityTableAccordionBox, {
Expand Down

0 comments on commit e12a4b0

Please sign in to comment.