Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add density to perennial/data/phet-io-api-stable #160

Closed
arouinfar opened this issue Apr 11, 2023 · 2 comments
Closed

Add density to perennial/data/phet-io-api-stable #160

arouinfar opened this issue Apr 11, 2023 · 2 comments
Assignees
@arouinfar
Labels
dev:phet-io

Comments

@arouinfar
Copy link
Contributor

Once the PhET-iO design of sim is stable, we usually designate the sim as phet-io-api-stable. Density is missing from the list in https://bayes.colorado.edu/dev/phettest/perennial/data/phet-io-api-stable, and it should probably be added.

@jonathanolson can you take care of this? You may also want to review the checklist in phetsims/reactants-products-and-leftovers#84 to see if anything else would apply to Density.
@arouinfar arouinfar mentioned this issue Apr 11, 2023
Closed
jonathanolson added a commit to phetsims/perennial that referenced this issue Apr 11, 2023
@jonathanolson
Add density to phet-io-api-stable (and adding compareDesignedAPIChang…
b42d360 
…es), see phetsims/density#160
jonathanolson added a commit that referenced this issue Apr 11, 2023
@jonathanolson
Add density to phet-io-api-stable (and adding compareDesignedAPIChang…
67286dc 
…es), see #160
@jonathanolson
Copy link
Contributor

Done above, can you verify?

@arouinfar
Copy link
Contributor Author

Thanks @jonathanolson, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arouinfar arouinfar

Labels
dev:phet-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @arouinfar